Implement some more predicates in the new solver #107102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
compiler-errors
commented
Jan 20, 2023
compiler-errors
commented
Jan 20, 2023
lcnr
added
S-waiting-on-author
compiler-errors
force-pushed
the
new-solver-new-candidats-4
branch
from
39c675d to
6aad347
Compare
|
@bors r=lcnr rollup (only affects new solver) |
|
📌 Commit 6aad347b3ccba9c14ec3321088b91e1c1a96cca0 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #107143) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
new-solver-new-candidats-4
branch
from
6aad347 to
bf31150
Compare
|
@bors r=lcnr |
|
📌 Commit bf311502596cf3e6ba687b7a26c06d7eef51153b has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
new-solver-new-candidats-4
branch
from
bf31150 to
444cbcd
Compare
|
@bors r=lcnr |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 21, 2023
…didats-4, r=lcnr
Implement some more predicates in the new solver
Implement a few more goals. The subtype goal specifically is important, since it's required for this code to compile:
```
fn main() {
let mut x = vec![];
x.push(1i32);
}
```
(I think we emit a subtype goal here because of coercion).
Drive-by: Also implements `--compare-mode=next-solver` -- I've been using this locally a lot to find out what works and what doesn't. I'm also happy to split this out into another PR.
r? `@lcnr`
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jan 22, 2023
…didats-4, r=lcnr
Implement some more predicates in the new solver
Implement a few more goals. The subtype goal specifically is important, since it's required for this code to compile:
```
fn main() {
let mut x = vec![];
x.push(1i32);
}
```
(I think we emit a subtype goal here because of coercion).
Drive-by: Also implements `--compare-mode=next-solver` -- I've been using this locally a lot to find out what works and what doesn't. I'm also happy to split this out into another PR.
r? ``@lcnr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 22, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107102 (Implement some more predicates in the new solver) - rust-lang#107111 (Fix missing arguments issues and copy-paste bug for fluent) - rust-lang#107114 (Add note about absolute paths to Path::join) - rust-lang#107127 (Enable sanitizers for s390x-linux) - rust-lang#107152 (Migrate scraped-examples top and bottom "borders" to CSS variables) - rust-lang#107170 (Add myself to .mailmap) - rust-lang#107174 (rustdoc: Use `DefId(Map,Set)` instead of `FxHash(Map,Set)`) - rust-lang#107180 (Remove unnecessary `&format!`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a few more goals. The subtype goal specifically is important, since it's required for this code to compile:
(I think we emit a subtype goal here because of coercion).
Drive-by: Also implements
--compare-mode=next-solver-- I've been using this locally a lot to find out what works and what doesn't. I'm also happy to split this out into another PR.r? @lcnr