Skip to content

Conversation

chenyukang
Copy link
Member

Fixes #107090

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 20, 2023

📌 Commit 6e14bef1a83f1da492542c1961cb9c7dd5479956 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
@bors

This comment was marked as resolved.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 20, 2023
@chenyukang chenyukang force-pushed the yukang/fix-107090-fluent-parameters branch from 6e14bef to 81efdab Compare January 20, 2023 15:50
@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 20, 2023

📌 Commit 81efdab has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 20, 2023
…t-parameters, r=petrochenkov

Fix missing arguments issues and copy-paste bug for fluent

Fixes rust-lang#107090
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107102 (Implement some more predicates in the new solver)
 - rust-lang#107111 (Fix missing arguments issues and copy-paste bug for fluent)
 - rust-lang#107114 (Add note about absolute paths to Path::join)
 - rust-lang#107127 (Enable sanitizers for s390x-linux)
 - rust-lang#107152 (Migrate scraped-examples top and bottom "borders" to CSS variables)
 - rust-lang#107170 (Add myself to .mailmap)
 - rust-lang#107174 (rustdoc: Use `DefId(Map,Set)` instead of `FxHash(Map,Set)`)
 - rust-lang#107180 (Remove unnecessary `&format!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6e79310 into rust-lang:master Jan 22, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICE]: the fluent string has an argument 'has_param_name' that was not found
4 participants