Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #86351 #109969

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add regression test for #86351 #109969

merged 1 commit into from
Apr 6, 2023

Conversation

JohnTitor
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 5, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 5, 2023

📌 Commit 5fe02bc3300c2c2d59abe490d853ed946272a0f2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2023
@compiler-errors
Copy link
Member

Wait actually, can you test to see if this fails with mir-opt level bumped up to 2? If so, the root cause hasn't really been fixed and maybe we should skip adding a test....

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 5, 2023
@JohnTitor
Add regression test for rust-lang#86351
b8e9076 
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@JohnTitor
Copy link
Member Author

I've included -Zmir-opt-level=2 and it passes on my local, can we say it's fixed by this?

@compiler-errors
Copy link
Member

Yeah seems fine..

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 5, 2023

📌 Commit b8e9076 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2023
@bors
Auto merge of rust-lang#109986 - JohnTitor:rollup-3aax38t, r=JohnTitor
8c7ad16 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#109909 (Deny `use`ing tool paths)
 - rust-lang#109921 (Don't ICE when encountering `dyn*` in statics or consts)
 - rust-lang#109922 (Disable `has_thread_local` on OpenHarmony)
 - rust-lang#109926 (write threads info into log only when debugging)
 - rust-lang#109968 (Add regression test for rust-lang#80409)
 - rust-lang#109969 (Add regression test for rust-lang#86351)
 - rust-lang#109973 (rustdoc: Improve logo display very small screen)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fe20ae0 into rust-lang:master Apr 6, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 6, 2023
@JohnTitor JohnTitor deleted the issue-86351 branch April 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

Rustc stable panics when optimizing MIR, attempting to unwrap trait object
4 participants
@JohnTitor @compiler-errors @bors @rustbot