Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix false positives for unused_parens around unary and binary operations #110257

Merged

Conversation

lukas-code
Copy link
Contributor

fix #110251

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2023
@lukas-code
Copy link
Contributor Author

wait why does this parse

fn what() {
    loop { if break {} }
}

but not

fn what() {
    loop { if return {} }
}

is this a bug or a feature?

@DaniPopes
Copy link
Contributor

I believe that can be answered in rust-quiz #20 😄

@lukas-code
Copy link
Contributor Author

lukas-code commented Apr 12, 2023

Yeah, looks like this is a feature, and removing the parens can change behavior, so not linting to remove them is correct.

@lukas-code
Copy link
Contributor Author

I pushed a second commit to deal with break more correctly.

@lukas-code lukas-code force-pushed the why-would-anyone-write-code-like-that-anyway branch from 8eb0bc9 to 0d0949d Compare April 13, 2023 16:13
@lukas-code lukas-code changed the title fix false positive for unused_parens around binary operations fix false positive for unused_parens around unary and binary operations Apr 13, 2023
@lukas-code lukas-code changed the title fix false positive for unused_parens around unary and binary operations fix false positives for unused_parens around unary and binary operations Apr 13, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 17, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 17, 2023

📌 Commit 0d0949d has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2023
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#104055 (Migrate diagnostics in `rustc_borrowck`)
 - rust-lang#110257 (fix false positives for `unused_parens` around unary and binary operations)
 - rust-lang#110313 (allow `repr(align = x)` on inherent methods)
 - rust-lang#110337 (Correct default value for default-linker-libraries)
 - rust-lang#110386 (Clean up traversal macros)
 - rust-lang#110394 (Various minor Idx-related tweaks)
 - rust-lang#110425 (Encode def span for `ConstParam`)
 - rust-lang#110434 (Check freeze with right param-env in `deduced_param_attrs`)
 - rust-lang#110455 (tests: adapt for LLVM change 5b386b8)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 06d12f6 into rust-lang:master Apr 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 17, 2023
@lukas-code lukas-code deleted the why-would-anyone-write-code-like-that-anyway branch April 17, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

false positive for unused_parens with binary op if rhs needs parens
5 participants