Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic types to SMIR #113412

Merged
merged 6 commits into from Jul 8, 2023
Merged

Add basic types to SMIR #113412

merged 6 commits into from Jul 8, 2023

Conversation

spastorino
Copy link
Member

Still incomplete but I think this can be merged and we can keep iterating over it.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

oli-obk
oli-obk requested changes Jul 6, 2023
View reviewed changes
compiler/rustc_smir/src/rustc_smir/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_smir/src/stable_mir/mod.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Jul 7, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 7, 2023

📌 Commit 9ca51b9 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jul 8, 2023
@compiler-errors
Rollup merge of rust-lang#113412 - spastorino:smir-types-1, r=oli-obk
ed2cc0d 
Add basic types to SMIR

Still incomplete but I think this can be merged and we can keep iterating over it.

r? `@oli-obk`
@compiler-errors compiler-errors mentioned this pull request Jul 8, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2023
@bors
Auto merge of rust-lang#113484 - matthiaskrgr:rollup-goq2u0d, r=matth…
d1389b9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112931 (Enable zlib in LLVM on aarch64-apple-darwin)
 - rust-lang#113158 (tests: unset `RUSTC_LOG_COLOR` in a test)
 - rust-lang#113173 (CI: include workflow name in concurrency group)
 - rust-lang#113335 (Reveal opaques in new solver)
 - rust-lang#113390 (CGU formation tweaks)
 - rust-lang#113399 (Structurally normalize again for byte string lit pat checking)
 - rust-lang#113412 (Add basic types to SMIR)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2023
Closed
@bors bors merged commit 39f558f into rust-lang:master Jul 8, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spastorino @rustbot @oli-obk @bors