Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing rvalues to smir #114165

Merged
merged 1 commit into from Aug 1, 2023
Merged

Add missing rvalues to smir #114165

merged 1 commit into from Aug 1, 2023

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Jul 28, 2023 •
edited by oli-obk

Added few missing rvalues to smir, not entirely confident about changes to Aggregate

cc rust-lang/project-stable-mir#13

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 28, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

oli-obk
oli-obk requested changes Jul 28, 2023
View reviewed changes
compiler/rustc_smir/src/rustc_smir/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_smir/src/rustc_smir/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_smir/src/stable_mir/ty.rs Outdated Show resolved Hide resolved
compiler/rustc_smir/src/stable_mir/mod.rs Outdated Show resolved Hide resolved
spastorino
spastorino reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@spastorino spastorino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general to me but I think I would add the uncovered mir::AggregateKind::Adt fields

compiler/rustc_smir/src/rustc_smir/mod.rs Outdated Show resolved Hide resolved
@spastorino
Copy link
Member

Can you squash the last commit? or maybe you can re-organize commits by variant covered. Whatever you prefer :).

@ouz-a
Copy link
Contributor Author

ouz-a commented Jul 31, 2023

Squashed it all into one commit it's clearer now, I think(?)

@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 31, 2023

📌 Commit 2a3da87 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 31, 2023
@bors
Auto merge of rust-lang#114308 - matthiaskrgr:rollup-m64bkm7, r=matth…
706a4d9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109318 (Make `Debug` representations of `[Lazy, Once]*[Cell, Lock]` consistent with `Mutex` and `RwLock`)
 - rust-lang#113701 (Re-export core::ffi::FromBytesUntilNulError in std::ffi)
 - rust-lang#113804 (Resolve correct archive version name in `opt-dist`)
 - rust-lang#114165 (Add missing rvalues to smir)
 - rust-lang#114182 (clean up after 113312)
 - rust-lang#114193 (Update lexer emoji diagnostics to Unicode 15.0)
 - rust-lang#114200 (Detect trait upcasting through struct tail unsizing in new solver select)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35ba616 into rust-lang:master Aug 1, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 1, 2023
@ouz-a ouz-a mentioned this pull request Aug 1, 2023
Closed
@ouz-a ouz-a deleted the smir1 branch August 10, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spastorino spastorino spastorino left review comments

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ouz-a @rustbot @spastorino @bors @oli-obk