Skip to content

Remove myself from the review rotation #114693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2023
Merged

Remove myself from the review rotation #114693

merged 2 commits into from
Aug 11, 2023

Conversation

pietroalbini
Copy link
Member

I'll go on vacation soon, and in general I've not been able to keep up with the reviews.

r? @Mark-Simulacrum

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 10, 2023

📌 Commit 26efc2f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2023
@compiler-errors compiler-errors mentioned this pull request Aug 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2023
@bors
Auto merge of rust-lang#114718 - compiler-errors:rollup-1am5rpn, r=co…
a07bc13 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114599 (Add impl trait declarations to SMIR)
 - rust-lang#114622 (rustc: Move `crate_types` and `stable_crate_id` from `Session` to `GlobalCtxt`)
 - rust-lang#114662 (Unlock trailing where-clauses for lazy type aliases)
 - rust-lang#114693 (Remove myself from the review rotation)
 - rust-lang#114694 (make the provisional cache slightly less broken)
 - rust-lang#114705 (Add spastorino to mailmap)
 - rust-lang#114712 (Fix a couple of bad comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2845bad into rust-lang:master Aug 11, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 11, 2023
@tgross35
Copy link
Contributor

@pietroalbini stumbled across this randomly, mailmap only accepts one replacement per line so the third email is just getting ignored

$ git shortlog -sne | rg 'Pietro'
   252	Pietro Albini <pietro.albini@ferrous-systems.com>
   171	Pietro Albini <pietro@pietroalbini.org>

@pietroalbini pietroalbini deleted the pa-pietro-review-rotation branch May 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @compiler-errors @bors @tgross35 @Mark-Simulacrum @rustbot