Skip to content

Conversation

ouz-a
Copy link
Contributor

@ouz-a ouz-a commented Sep 9, 2023

Addressees rust-lang/project-stable-mir#31

Maybe we should change Span = Opaque into something else, and then return String with newly added function, I don't think it matters that much though, since we are not storing Span anywhere.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@oli-obk
Copy link
Contributor

oli-obk commented Sep 9, 2023

Yea, I wanna change Span to be able to add methods on it that query data from TyCtxt. This PR is orthogonal to that tho

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

📌 Commit d190ebf has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2023
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

⌛ Testing commit d190ebf with merge c1b38c7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2023
Add function that returns span of an item in smir

Addressees rust-lang/project-stable-mir#31

Maybe we should change `Span = Opaque` into something else, and then return `String` with newly added function, I don't think it matters that much though, since we are not storing `Span` anywhere.

r? `@oli-obk`
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing c1b38c7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 9, 2023
@bors
Copy link
Collaborator

bors commented Sep 9, 2023

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c1b38c7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.9%, -0.7%] 3
Improvements ✅
(secondary)
-4.2% [-4.2%, -4.2%] 1
All ❌✅ (primary) -1.4% [-1.9%, -0.7%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.91s -> 629.541s (0.10%)
Artifact size: 318.15 MiB -> 318.14 MiB (-0.01%)

@compiler-errors
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

⌛ Testing commit d190ebf with merge 8ed4537...

@bors
Copy link
Collaborator

bors commented Sep 9, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 8ed4537 to master...

@bors bors merged commit 8ed4537 into rust-lang:master Sep 9, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 9, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8ed4537): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.555s -> 627.878s (-0.11%)
Artifact size: 317.86 MiB -> 317.90 MiB (0.01%)

@ouz-a ouz-a deleted the smir_span branch September 10, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants