Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Ready::into_inner() #116528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stabilize Ready::into_inner() #116528

wants to merge 2 commits into from

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Oct 8, 2023

This PR stabilizes Ready::into_inner().

Tracking issue: #101196.
Implementation PR: #101189.

Closes #101196.

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2023
@daxpedda daxpedda mentioned this pull request Oct 8, 2023
Open
3 tasks
@cuviper
Copy link
Member

cuviper commented Oct 9, 2023

@rustbot label -T-libs +T-libs-api
r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 9, 2023
@rustbot rustbot assigned dtolnay and unassigned cuviper Oct 9, 2023
@dtolnay
Copy link
Member

dtolnay commented Oct 10, 2023

FCP proposed: #101196 (comment)

@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023
@dtolnay dtolnay added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Mar 30, 2024
@Dylan-DPC Dylan-DPC added the S-tracking-design-concerns Status: There are blocking ❌ design concerns. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. S-tracking-design-concerns Status: There are blocking ❌ design concerns. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Ready::into_inner()
5 participants
@daxpedda @rustbot @cuviper @dtolnay @Dylan-DPC