Add -Zunpretty=stable-mir output test #118375

ouz-a · 2023-11-27T15:44:14Z

As strongly suggested here #118364 (comment) this adds output test for -Zunpretty=stable-mir, added test shows almost all the functionality of the current printer.

r? @compiler-errors

compiler-errors · 2023-11-27T15:48:31Z

r=me when green

compiler-errors · 2023-11-27T16:24:00Z

@bors r+ rollup

bors · 2023-11-27T16:24:03Z

📌 Commit 9e9ca4a has been approved by compiler-errors

It is now in the queue for this repository.

…=compiler-errors Add -Zunpretty=stable-mir output test As strongly suggested here rust-lang#118364 (comment) this adds output test for `-Zunpretty=stable-mir`, added test shows almost all the functionality of the current printer. r? `@compiler-errors`

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118282 (effects: Run `enforce_context_effects` for all method calls) - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints) - rust-lang#118375 (Add -Zunpretty=stable-mir output test) r? `@ghost` `@rustbot` modify labels: rollup

…=compiler-errors Add -Zunpretty=stable-mir output test As strongly suggested here rust-lang#118364 (comment) this adds output test for `-Zunpretty=stable-mir`, added test shows almost all the functionality of the current printer. r? ``@compiler-errors``

compiler-errors · 2023-11-27T23:13:39Z

This caused a test failure in #118380 (comment)

@bors r-

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118341 (Simplify indenting in THIR printing) - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints) - rust-lang#118375 (Add -Zunpretty=stable-mir output test) - rust-lang#118381 (rustc_span: Use correct edit distance start length for suggestions) - rust-lang#118384 (Address unused tuple struct fields in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup

rustbot · 2023-11-28T07:50:56Z

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

ouz-a · 2023-11-28T07:57:24Z

I don't know why test failed but added -Z mir-opt-level=3 and removed todo! from pretty printer

compiler/stable_mir/src/mir/pretty.rs

tests/ui/stable-mir-print/basic_function.stdout

bors · 2023-12-02T18:57:33Z

☔ The latest upstream changes (presumably #118543) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2023-12-12T21:08:55Z

☔ The latest upstream changes (presumably #118881) made this pull request unmergeable. Please resolve the merge conflicts.

celinval · 2023-12-12T23:35:01Z

Hey @ouz-a, I was wondering what's blocking you in this PR.

compiler/stable_mir/src/mir/pretty.rs

…=celinval Add -Zunpretty=stable-mir output test As strongly suggested here rust-lang#118364 (comment) this adds output test for `-Zunpretty=stable-mir`, added test shows almost all the functionality of the current printer. r? `@compiler-errors`

…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#118375 (Add -Zunpretty=stable-mir output test) - rust-lang#118538 (fix dynamic size/align computation logic for packed types with dyn trait tail) - rust-lang#118789 (fix --dry-run when the change-id warning is printed) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2023-12-14T06:56:57Z

⌛ Testing commit 0a0231c with merge 445ba56...

…elinval Add -Zunpretty=stable-mir output test As strongly suggested here rust-lang#118364 (comment) this adds output test for `-Zunpretty=stable-mir`, added test shows almost all the functionality of the current printer. r? `@compiler-errors`

bors · 2023-12-14T07:18:01Z

💔 Test failed - checks-actions

ouz-a · 2023-12-14T15:11:46Z

Added flag to test so it only runs on x86_64 so hopefully it doesn't break this time.

ouz-a · 2023-12-14T17:25:38Z

@bors r=celinval

bors · 2023-12-14T17:25:41Z

📌 Commit 82ee18c has been approved by celinval

It is now in the queue for this repository.

bors · 2023-12-14T19:17:55Z

⌛ Testing commit 82ee18c with merge 740cea8...

bors · 2023-12-14T21:19:41Z

☀️ Test successful - checks-actions
Approved by: celinval
Pushing 740cea8 to master...

rust-timer · 2023-12-14T22:41:23Z

Finished benchmarking commit (740cea8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	2.6%	[1.0%, 4.2%]	2
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-1.2%, 1.9%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	0.2%	[-0.8%, 0.8%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.223s -> 672.412s (-0.12%)
Artifact size: 312.46 MiB -> 312.48 MiB (0.01%)

rustbot assigned compiler-errors Nov 27, 2023

ouz-a changed the title ~~Add stable_mir output test~~ Add -Zunpretty=stable-mir output test Nov 27, 2023

ouz-a mentioned this pull request Nov 27, 2023

Fix misc printing issues in emit=stable_mir #118364

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2023

matthiaskrgr mentioned this pull request Nov 27, 2023

Rollup of 6 pull requests #118380

Closed

GuillaumeGomez mentioned this pull request Nov 27, 2023

Rollup of 8 pull requests #118387

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2023

ouz-a force-pushed the add_emit_stable_mir_tests branch from 9e9ca4a to a44f6c6 Compare November 28, 2023 07:50

This comment has been minimized.

Sign in to view

ouz-a force-pushed the add_emit_stable_mir_tests branch from a44f6c6 to 17e7ca3 Compare November 28, 2023 08:31

celinval reviewed Nov 29, 2023

View reviewed changes

compiler/stable_mir/src/mir/pretty.rs Show resolved Hide resolved

tests/ui/stable-mir-print/basic_function.stdout Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2023

matthiaskrgr reviewed Dec 13, 2023

View reviewed changes

compiler/stable_mir/src/mir/pretty.rs Outdated Show resolved Hide resolved

matthiaskrgr mentioned this pull request Dec 14, 2023

Rollup of 3 pull requests #118932

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2023

ouz-a force-pushed the add_emit_stable_mir_tests branch from 0a0231c to 0d3f1f9 Compare December 14, 2023 08:38

compiler-errors assigned celinval and unassigned compiler-errors Dec 14, 2023

add stable_mir output test

82ee18c

ouz-a force-pushed the add_emit_stable_mir_tests branch from 0d3f1f9 to 82ee18c Compare December 14, 2023 15:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 14, 2023

bors merged commit 740cea8 into rust-lang:master Dec 14, 2023

rustbot added this to the 1.76.0 milestone Dec 14, 2023

This was referenced Dec 14, 2023

Stabilize THIR unsafeck #117673

Merged

Make traits / trait methods detected by the dead code lint #118257

Merged

Add -Zunpretty=stable-mir output test #118375

Add -Zunpretty=stable-mir output test #118375

Uh oh!

Conversation

ouz-a commented Nov 27, 2023

Uh oh!

compiler-errors commented Nov 27, 2023

Uh oh!

compiler-errors commented Nov 27, 2023

Uh oh!

bors commented Nov 27, 2023

Uh oh!

compiler-errors commented Nov 27, 2023

Uh oh!

rustbot commented Nov 28, 2023

Uh oh!

ouz-a commented Nov 28, 2023

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

bors commented Dec 2, 2023

Uh oh!

bors commented Dec 12, 2023

Uh oh!

celinval commented Dec 12, 2023

Uh oh!

Uh oh!

bors commented Dec 14, 2023

Uh oh!

This comment has been minimized.

bors commented Dec 14, 2023

Uh oh!

ouz-a commented Dec 14, 2023

Uh oh!

ouz-a commented Dec 14, 2023

Uh oh!

bors commented Dec 14, 2023

Uh oh!

bors commented Dec 14, 2023

Uh oh!

bors commented Dec 14, 2023

Uh oh!

rust-timer commented Dec 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!