Skip to content

Conversation

compiler-errors
Copy link
Member

Coroutines are never polymorphic in their signature. This cleans up a FIXME in the code:

    /// Returns the "coroutine signature", which consists of its yield
    /// and return types.
    ///
    /// N.B., some bits of the code prefers to see this wrapped in a
    /// binder, but it never contains bound regions. Probably this
    /// function should be removed.

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2023
@compiler-errors compiler-errors changed the title Yeet PolyGenSig Remove PolyGenSig since it's always a dummy binder Dec 6, 2023
@compiler-errors
Copy link
Member Author

r? types

@rustbot rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Dec 6, 2023
@rustbot rustbot assigned spastorino and unassigned davidtwco Dec 6, 2023
@spastorino
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 6, 2023

📌 Commit 1ec3ef7 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2023
@bors
Copy link
Collaborator

bors commented Dec 7, 2023

⌛ Testing commit 1ec3ef7 with merge 670188c...

@bors
Copy link
Collaborator

bors commented Dec 7, 2023

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 670188c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 7, 2023
@bors bors merged commit 670188c into rust-lang:master Dec 7, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (670188c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [0.5%, 2.0%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-2.5%, 2.0%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.39s -> 676.141s (0.26%)
Artifact size: 314.17 MiB -> 314.20 MiB (0.01%)

celinval added a commit to model-checking/kani that referenced this pull request Dec 8, 2023
Updates the Rust toolchain to `nightly-2023-12-08`. The relevant changes
are:
 * rust-lang/rust#118324
 * rust-lang/rust#118684

---------

Co-authored-by: Celina G. Val <celinval@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants