Also walk bindings created by if-let guards #119402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
est31
force-pushed
the
fix_if_guard_unused
branch
from
264fb7f
to
fdec5b6
Compare
This comment has been minimized.
This comment has been minimized.
est31
force-pushed
the
fix_if_guard_unused
branch
from
fdec5b6
to
ab60a7d
Compare
compiler-errors
approved these changes
Dec 29, 2023
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119375 (Merge Coroutine lowering functions) - rust-lang#119393 (Use filter instead of filter_map in Parser::expected_one_of_not_found) - rust-lang#119401 (coverage: Avoid a possible query stability hazard in `CoverageCounters`) - rust-lang#119402 (Also walk bindings created by if-let guards) - rust-lang#119404 (Enable profiler in dist-powerpc-linux) r? `@ghost` `@rustbot` modify labels: rollup
Nilstrieb
approved these changes
Dec 29, 2023
| @@ -0,0 +1,9 @@ | |||
| #![feature(if_let_guard)] | |||
There was a problem hiding this comment.
instead of giving this a meaningless issue number as a name, can we give it a descriptive name like "if-let-guard"?
|
Oh errs already reviewed it, didn't see that lol. A test rename would still be appreciated as a follow up :) |
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 29, 2023
Rollup merge of rust-lang#119402 - est31:fix_if_guard_unused, r=compiler-errors Also walk bindings created by if-let guards This change makes the `unused_variables` lint pick up unused bindings created by if-let guards. Fixes rust-lang#119383
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2023
…rieb Rename test to be more descriptive As suggested in rust-lang#119402 (comment) r? `@Nilstrieb`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2023
…rieb Rename test to be more descriptive As suggested in rust-lang#119402 (comment) r? ``@Nilstrieb``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 30, 2023
Rollup merge of rust-lang#119410 - est31:fix_if_guard_unused, r=Nilstrieb Rename test to be more descriptive As suggested in rust-lang#119402 (comment) r? ``@Nilstrieb``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
unused_variableslint pick up unused bindings created by if-let guards.Fixes #119383