Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename test to be more descriptive #119410

Merged
merged 1 commit into from Dec 30, 2023
Merged

Rename test to be more descriptive #119410

merged 1 commit into from Dec 30, 2023

Conversation

est31
Copy link
Member

@est31 est31 commented Dec 29, 2023

As suggested in #119402 (comment)

r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2023
Nilstrieb
Nilstrieb approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@Nilstrieb Nilstrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

in my opinion the issue number shouldn't be in the test at all as it has no real relevance here but it's fine like this

@Nilstrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 29, 2023

📌 Commit 740378c has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 29, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#119410 - est31:fix_if_guard_unused, r=Nilst…
6b08b8f 
…rieb

Rename test to be more descriptive

As suggested in rust-lang#119402 (comment)

r? `@Nilstrieb`
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 29, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
@bors
Auto merge of rust-lang#119421 - matthiaskrgr:rollup-dbera1b, r=matth…
03b5019 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119322 (Couple of random coroutine pass simplifications)
 - rust-lang#119374 (Italicise "bytes" in the docs of some `Vec` methods)
 - rust-lang#119388 (rustc_lint: Prevent triplication of various lints)
 - rust-lang#119406 (Add non-regression test for ATPIT ICE rust-lang#114325)
 - rust-lang#119410 (Rename test to be more descriptive)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfc1643 into rust-lang:master Dec 30, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2023
@rust-timer
Unrolled build for rust-lang#119410
6b1dcea 
Rollup merge of rust-lang#119410 - est31:fix_if_guard_unused, r=Nilstrieb

Rename test to be more descriptive

As suggested in rust-lang#119402 (comment)

r? ``@Nilstrieb``
@rustbot rustbot added this to the 1.77.0 milestone Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nilstrieb Nilstrieb Nilstrieb approved these changes

Assignees

@Nilstrieb Nilstrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@est31 @Nilstrieb @bors @rustbot