Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline 2 functions that appear in dep-graph profiles. #119960

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jan 14, 2024

Those functions are small enough not to deserve a dedicated symbol.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 14, 2024
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
Inline 2 functions that appear in dep-graph profiles.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Jan 14, 2024

⌛ Trying commit c6f83b8 with merge 7811646...

@bors
Copy link
Contributor

bors commented Jan 14, 2024

☀️ Try build successful - checks-actions
Build commit: 7811646 (78116462cbd48aee7c1a600ade64265b659af8ab)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7811646): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.3% [-1.3%, -1.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.597s -> 669.203s (0.09%)
Artifact size: 308.21 MiB -> 308.22 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 14, 2024
@cjgillot cjgillot marked this pull request as ready for review January 14, 2024 15:51
@cjgillot
Copy link
Contributor Author

r? compiler

@WaffleLapkin
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 14, 2024

📌 Commit c6f83b8 has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119561 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5))
 - rust-lang#119742 (ARMv6K HorizonOS - Fix backlog for UnixListener)
 - rust-lang#119960 (Inline 2 functions that appear in dep-graph profiles.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d635cec into rust-lang:master Jan 14, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2024
Rollup merge of rust-lang#119960 - cjgillot:inline-dg, r=WaffleLapkin

Inline 2 functions that appear in dep-graph profiles.

Those functions are small enough not to deserve a dedicated symbol.
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
@cjgillot cjgillot deleted the inline-dg branch January 14, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants