Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #119970

Merged
merged 8 commits into from
Jan 14, 2024
Merged

Rollup of 3 pull requests #119970

merged 8 commits into from
Jan 14, 2024

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

notriddle and others added 8 commits January 3, 2024 15:33
@notriddle
Add crate_name and URL to test cases
b5c9982
@notriddle
rustdoc: rename issue-\d+.rs tests to have meaningful names (part 5)
35830fe
@notriddle
Add check-pass to ice tests
a704e21
@Meziu
Backlog for HorizonOS UnixListener
7a7bb3e
@cjgillot
Inline 2 functions that appear in dep-graph profiles.
c6f83b8
@GuillaumeGomez
Rollup merge of rust-lang#119561 - notriddle:master, r=fmease
8914ca7 
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
@GuillaumeGomez
Rollup merge of rust-lang#119742 - Meziu:armv6k-nintendo-3ds, r=Mark-…
e401754 
…Simulacrum

ARMv6K HorizonOS - Fix backlog for UnixListener

Simple `#[cfg]` fix to avoid using `libc::SOMAXCONN`, which isn't defined for the `armv6k-nintendo-3ds` target.

Edit: This is similar to rust-lang#119632.
@GuillaumeGomez
Rollup merge of rust-lang#119960 - cjgillot:inline-dg, r=WaffleLapkin
d635cec 
Inline 2 functions that appear in dep-graph profiles.

Those functions are small enough not to deserve a dedicated symbol.
@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 14, 2024
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Contributor

bors commented Jan 14, 2024

📌 Commit d635cec has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2024
@bors
Copy link
Contributor

bors commented Jan 14, 2024

⌛ Testing commit d635cec with merge 30dfb9e...

@bors
Copy link
Contributor

bors commented Jan 14, 2024

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 30dfb9e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 14, 2024
@bors bors merged commit 30dfb9e into rust-lang:master Jan 14, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 14, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119561 rustdoc: rename issue-\d+.rs tests to have meaningful nam… 428e71b4b21213c0b600f9727e816d3e8878dcd7 (link)
#119742 ARMv6K HorizonOS - Fix backlog for UnixListener a7a8489220efba8bb8aaafa587dee133924f35ab (link)
#119960 Inline 2 functions that appear in dep-graph profiles. 11ed1e535b741785f09747c249055e4049359d16 (link)

previous master: 665d2c6f2c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez GuillaumeGomez deleted the rollup-p53c19o branch January 14, 2024 23:15
@bors bors mentioned this pull request Jan 15, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (30dfb9e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [4.9%, 4.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.109s -> 668.845s (0.41%)
Artifact size: 308.19 MiB -> 308.21 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @bors @rust-timer @rustbot @notriddle @Meziu @cjgillot