mk: make NO_REBUILD more forceful and more general. #12237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously crates like `green` and `native` would still depend on their parents when running `make check-stage2-green NO_REBUILD=1`, this ensures that they only depend on their source files. Also, apply NO_REBUILD to the crate doc tests, so, for example, `check-stage2-doc-std` will use an already compiled `rustdoc` directly.
|
r? @alexcrichton or @pnkfelix |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
…=Jarcho Check trait items in `min_ident_chars` Fix rust-lang#12237. changelog: [`min_ident_chars`]: check trait items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously crates like
greenandnativewould still depend on theirparents when running
make check-stage2-green NO_REBUILD=1, thisensures that they only depend on their source files.
Also, apply NO_REBUILD to the crate doc tests, so, for example,
check-stage2-doc-stdwill use an already compiledrustdocdirectly.