sys_common::thread_local_key: make a note that this is not used on Windows #123589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use |
rustbot
added
S-waiting-on-review
|
This should definitely be solved by our (on going) reorganisation of @bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2024
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#123584 (Emit an error when `rustc_doc_primitive` has an unknown value) - rust-lang#123589 (sys_common::thread_local_key: make a note that this is not used on Windows) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2024
Rollup merge of rust-lang#123589 - RalfJung:nowin, r=ChrisDenton sys_common::thread_local_key: make a note that this is not used on Windows This just confused me for a while. I don't have the time to clean it up but I can at least leave a note for the next wary traveler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just confused me for a while. I don't have the time to clean it up but I can at least leave a note for the next wary traveler.