Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 7, 2024

This just confused me for a while. I don't have the time to clean it up but I can at least leave a note for the next wary traveler.

@RalfJung RalfJung marked this pull request as ready for review April 7, 2024 10:24
@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2024

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 7, 2024
@ChrisDenton
Copy link
Member

This should definitely be solved by our (on going) reorganisation of sys rather than in a comment. I guess though a comment is fine until then.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 7, 2024

📌 Commit b1d1ad9 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2024
@ChrisDenton
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2024
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#123584 (Emit an error when `rustc_doc_primitive` has an unknown value)
 - rust-lang#123589 (sys_common::thread_local_key: make a note that this is not used on Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e5bdd7e into rust-lang:master Apr 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2024
Rollup merge of rust-lang#123589 - RalfJung:nowin, r=ChrisDenton

sys_common::thread_local_key: make a note that this is not used on Windows

This just confused me for a while. I don't have the time to clean it up but I can at least leave a note for the next wary traveler.
@rustbot rustbot added this to the 1.79.0 milestone Apr 7, 2024
@RalfJung RalfJung deleted the nowin branch April 8, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants