Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracking issue for const_binary_heap_new_in #125962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Coekjan
Copy link
Contributor

@Coekjan Coekjan commented Jun 4, 2024

This PR updates the tracking issue of const_binary_heap_new_in feature:

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 4, 2024
@Coekjan Coekjan changed the title update tracking issue for const_binary_heap_new_in Update tracking issue for const_binary_heap_new_in Jun 4, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Jun 4, 2024

Ah I assumed it was just going to be paired with #32838 when stabilizing the new_in method

@Coekjan
Copy link
Contributor Author

Coekjan commented Jun 4, 2024

Ah I assumed it was just going to be paired with #32838 when stabilizing the new_in method

Thank you for your feedback!

I believe the const_binary_heap_new_in feature has a different feature gate from #32838 (allocator_api). Therefore, it should be stabilized separately after #32838 is stabilized. However, if it's feasible to merge it into the allocator_api feature, that might be a better approach.

@joboet
Copy link
Contributor

joboet commented Jun 10, 2024

For me, merging into allocator_api makes sense, but let's see what someone from the API team has to say.
r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 10, 2024
@rustbot rustbot assigned m-ou-se and unassigned joboet Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants