New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the name of the copyright holder and year #13391

Merged
merged 1 commit into from May 4, 2014

Conversation

Projects
None yet
6 participants
@smesseim
Contributor

smesseim commented Apr 7, 2014

The years of copyright and the name of the copyright holder were not
present in the notice.

The Apache license was added to the project in 2012, so 2012 is the
starting year. The copyright holder is the Mozilla Foundation (taken
from the MIT license).

@thestinger

This comment has been minimized.

Contributor

thestinger commented Apr 7, 2014

I don't think a starting year is either necessary or useful, and 2012 would not be right if it was. The Mozilla Foundation is also only one of many copyright holders - the MIT license file is wrong.

@cmr

This comment has been minimized.

Member

cmr commented Apr 7, 2014

The copyright belongs to "The Rust Project Developers" according to COPYRIGHT and every single source file.

@smesseim

This comment has been minimized.

Contributor

smesseim commented Apr 8, 2014

I assume the copyright in the MIT license should also be changed to:

Copyright (c) 2006-2009 Graydon Hoare
Copyright (c) 2009-2012 Mozilla Foundation
Copyright (c) 2012-2014 The Rust Project Developers
@smesseim

This comment has been minimized.

Contributor

smesseim commented Apr 8, 2014

@thestinger

This comment has been minimized.

Contributor

thestinger commented Apr 8, 2014

Since it's all we use in other files, "The Rust Project Developers" is all that's needed in here. The range of dates is meaningless because it has no meaning in copyright law - the published date does, and that's 2014 for the contents of master. That's why the template licenses never ask for a range.

@brson

This comment has been minimized.

Contributor

brson commented Apr 12, 2014

That LICENSE-MIT was wrong has long bugged me. I also agree "The Rust Project Developers" and 2014 is sufficient.

LICENSE-APACHE does not need to change though. That line is actually part of the appendix, which is a template explaining how to use the license - I don't think it's intended to be changed.

@brson

This comment has been minimized.

Contributor

brson commented Apr 16, 2014

@inlock sorry for the runaround, but I'd like to remove the copyright lines for Graydon and the Mozilla Foundation from LICENSE-MIT as well.

@alexcrichton

This comment has been minimized.

Member

alexcrichton commented May 2, 2014

Sorry this went under the radar for so long @smesseim! Feel free to comment on a PR when you update it, because sadly we don't get any notifications when it's force-pushed.

Could you squash these commits into just one commit? Thanks again, and sorry for the delay!

Change the licence holder to The Rust Project Developers
The copyright of this project belongs to The Rust Project Developers,
who are mentioned in AUTHORS.txt.
@smesseim

This comment has been minimized.

Contributor

smesseim commented May 3, 2014

The commits are squashed into one commit.

@bors

This comment has been minimized.

Contributor

bors commented on 90ba013 May 4, 2014

saw approval from alexcrichton
at smesseim@90ba013

This comment has been minimized.

Contributor

bors replied May 4, 2014

merging smesseim/rust/apache-copyright = 90ba013 into auto

This comment has been minimized.

Contributor

bors replied May 4, 2014

smesseim/rust/apache-copyright = 90ba013 merged ok, testing candidate = a621f82

This comment has been minimized.

Contributor

bors replied May 4, 2014

saw approval from alexcrichton
at smesseim@90ba013

This comment has been minimized.

Contributor

bors replied May 4, 2014

merging smesseim/rust/apache-copyright = 90ba013 into auto

This comment has been minimized.

Contributor

bors replied May 4, 2014

smesseim/rust/apache-copyright = 90ba013 merged ok, testing candidate = 0f9a74f

This comment has been minimized.

Contributor

bors replied May 4, 2014

fast-forwarding master to auto = 0f9a74f

bors added a commit that referenced this pull request May 4, 2014

auto merge of #13391 : smesseim/rust/apache-copyright, r=alexcrichton
The years of copyright and the name of the copyright holder were not
present in the notice.

The Apache license was added to the project in 2012, so 2012 is the
starting year. The copyright holder is the Mozilla Foundation (taken
from the MIT license).

bors added a commit that referenced this pull request May 4, 2014

auto merge of #13391 : smesseim/rust/apache-copyright, r=alexcrichton
The years of copyright and the name of the copyright holder were not
present in the notice.

The Apache license was added to the project in 2012, so 2012 is the
starting year. The copyright holder is the Mozilla Foundation (taken
from the MIT license).

@bors bors merged commit 90ba013 into rust-lang:master May 4, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed

@smesseim smesseim deleted the smesseim:apache-copyright branch May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment