mk: Fix make install #14033
Merged
mk: Fix make install #14033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to update the installation procedure with the knowledge that libcore is only available as an rlib, not as a dylib. Closes rust-lang#14026
| @@ -133,7 +134,8 @@ prepare-target-$(2)-host-$(3)-$(1)-$(4): prepare-maybe-clean-$(4) \ | |||
| $$(if $$(findstring $(3), $$(PREPARE_HOST)),\ | |||
| $$(call PREPARE_DIR,$$(PREPARE_WORKING_DEST_LIB_DIR))\ | |||
| $$(foreach crate,$$(TARGET_CRATES),\ | |||
| $$(call PREPARE_LIB,$$(call CFG_LIB_GLOB_$(2),$$(crate)))\ | |||
| $$(if $$(findstring 1, $$(ONLY_RLIB_$$(crate))),,\ | |||
There was a problem hiding this comment.
It’s the dreaded tab monster!
There was a problem hiding this comment.
I approved due to it blocking make install, but I guess it would be nice to fix this at some point.
bors
added a commit
that referenced
this pull request
May 8, 2014
Forgot to update the installation procedure with the knowledge that libcore is only available as an rlib, not as a dylib. Closes #14026
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
Checks for functions with method calls to `.map(_)` on an arg of type `Option` as the outermost expression. Fixes rust-lang#774 ``` changelog: [`single_option_map`]: Checks for functions with method calls to `.map(_)` on an arg of type `Option` as the outermost expression. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to update the installation procedure with the knowledge that libcore is
only available as an rlib, not as a dylib.
Closes #14026