libcore: remove fails from slice.rs and remove duplicated length checking #14150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1214,11 +1224,12 @@ pub mod raw { | |||
| * slice so it no longer contains that element. Fails if | |||
| * slice is empty. O(1). | |||
There was a problem hiding this comment.
This documentation will need to be updated
|
Can you re-word the commit message with respect to the breaking change of |
…king
core::slice::raw::{shift_ptr,pop_ptr} now returns Option<*T> rather than
*T. They no longer fail on empty slices.
[breaking-change]
|
@alexcrichton Updated (also fixed a docstring for |
|
LGTM. r=me if @alexcrichton is happy with the commit message. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 20, 2023
internal: Don't allocate the generic_args vec in `hir_def::Path` if it consists only of `None` args Saves roughly 5mb on self
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.