Stabilize `const_float_round_methods` #143604

nxsaken · 2025-07-07T18:52:43Z

Closes #141555, waiting for FCP.

rustbot · 2025-07-07T18:52:48Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-07-07T21:04:52Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

library/core/src/intrinsics/mod.rs

traviscross · 2025-07-09T15:49:11Z

Thanks to @nxsaken for putting up the stabilization PR.

@rfcbot fcp merge

cc @rust-lang/lang @rust-lang/opsem @RalfJung @rust-lang/libs-api

rfcbot · 2025-07-09T15:49:16Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

rfcbot · 2025-07-19T16:11:24Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

RalfJung · 2025-07-19T16:39:14Z

@nxsaken please rebase to resolve the conflicts, then we can land this :)

intrinsics

RalfJung · 2025-07-19T20:19:22Z

Thanks!
@bors r+ rollup

bors · 2025-07-19T20:19:24Z

📌 Commit caf4f11 has been approved by RalfJung

It is now in the queue for this repository.

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

Rollup of 12 pull requests Successful merges: - #141260 (Allow volatile access to non-Rust memory, including address 0) - #143604 (Stabilize `const_float_round_methods`) - #143833 (Ban projecting into SIMD types [MCP838]) - #143988 ([rustdoc] Make aliases search support partial matching) - #144078 (Fix debuginfo-lto-alloc.rs test) - #144111 (Remove deprecated `MaybeUninit` slice methods) - #144116 (Fixes for LLVM 21) - #144134 (Cleanup unicode table gen) - #144142 (Add implicit sized bound to trait ascription types) - #144148 (Remove pretty print hack for async blocks) - #144169 (interpret: fix TypeId pointers being considered data pointers) - #144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - #141260 (Allow volatile access to non-Rust memory, including address 0) - #143604 (Stabilize `const_float_round_methods`) - #143988 ([rustdoc] Make aliases search support partial matching) - #144078 (Fix debuginfo-lto-alloc.rs test) - #144111 (Remove deprecated `MaybeUninit` slice methods) - #144116 (Fixes for LLVM 21) - #144134 (Cleanup unicode table gen) - #144142 (Add implicit sized bound to trait ascription types) - #144148 (Remove pretty print hack for async blocks) - #144169 (interpret: fix TypeId pointers being considered data pointers) - #144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143604 - nxsaken:const_float_round_methods, r=RalfJung Stabilize `const_float_round_methods` Closes #141555, waiting for FCP.

Rollup of 11 pull requests Successful merges: - rust-lang/rust#141260 (Allow volatile access to non-Rust memory, including address 0) - rust-lang/rust#143604 (Stabilize `const_float_round_methods`) - rust-lang/rust#143988 ([rustdoc] Make aliases search support partial matching) - rust-lang/rust#144078 (Fix debuginfo-lto-alloc.rs test) - rust-lang/rust#144111 (Remove deprecated `MaybeUninit` slice methods) - rust-lang/rust#144116 (Fixes for LLVM 21) - rust-lang/rust#144134 (Cleanup unicode table gen) - rust-lang/rust#144142 (Add implicit sized bound to trait ascription types) - rust-lang/rust#144148 (Remove pretty print hack for async blocks) - rust-lang/rust#144169 (interpret: fix TypeId pointers being considered data pointers) - rust-lang/rust#144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#141260 (Allow volatile access to non-Rust memory, including address 0) - rust-lang#143604 (Stabilize `const_float_round_methods`) - rust-lang#143988 ([rustdoc] Make aliases search support partial matching) - rust-lang#144078 (Fix debuginfo-lto-alloc.rs test) - rust-lang#144111 (Remove deprecated `MaybeUninit` slice methods) - rust-lang#144116 (Fixes for LLVM 21) - rust-lang#144134 (Cleanup unicode table gen) - rust-lang#144142 (Add implicit sized bound to trait ascription types) - rust-lang#144148 (Remove pretty print hack for async blocks) - rust-lang#144169 (interpret: fix TypeId pointers being considered data pointers) - rust-lang#144196 (Initialize mingw for the runner's user) r? `@ghost` `@rustbot` modify labels: rollup

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

rustbot assigned Mark-Simulacrum Jul 7, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 7, 2025

This comment has been minimized.

Sign in to view

nxsaken force-pushed the const_float_round_methods branch from 2fc9d9b to 5df1124 Compare July 7, 2025 19:39

This comment has been minimized.

Sign in to view

nxsaken marked this pull request as draft July 7, 2025 19:56

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025

nxsaken force-pushed the const_float_round_methods branch from 5df1124 to c7002be Compare July 7, 2025 20:24

nxsaken marked this pull request as ready for review July 7, 2025 21:04

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025

nxsaken commented Jul 7, 2025

View reviewed changes

library/core/src/intrinsics/mod.rs Show resolved Hide resolved

traviscross added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Jul 9, 2025

This comment was marked as duplicate.

Sign in to view

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

This comment was marked as resolved.

Sign in to view

rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

traviscross removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 9, 2025

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2025

traviscross added I-lang-radar Items that are on lang's radar and will need eventual work or consideration. and removed I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 9, 2025

rustbot mentioned this pull request Jul 19, 2025

Tracking issue for release notes of #143604: Stabilize const_float_round_methods #144184

Closed

nxsaken added 2 commits July 20, 2025 00:08

Stabilize const_float_round_methods

ca01e7d

Add #[rustc_intrinsic_const_stable_indirect] to float rounding

caf4f11

intrinsics

nxsaken force-pushed the const_float_round_methods branch from c7002be to caf4f11 Compare July 19, 2025 20:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 20, 2025

Rollup merge of rust-lang#143604 - nxsaken:const_float_round_methods,…

efc7e4b

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

jhpratt mentioned this pull request Jul 20, 2025

Rollup of 13 pull requests #144202

Closed

fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 20, 2025

Rollup merge of rust-lang#143604 - nxsaken:const_float_round_methods,…

3a8853e

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

fee1-dead mentioned this pull request Jul 20, 2025

Rollup of 12 pull requests #144204

Closed

matthiaskrgr mentioned this pull request Jul 20, 2025

Rollup of 11 pull requests #144208

Merged

bors merged commit a8c2e54 into rust-lang:master Jul 20, 2025
10 of 11 checks passed

rustbot added this to the 1.90.0 milestone Jul 20, 2025

rust-timer added a commit that referenced this pull request Jul 20, 2025

Unrolled build for #143604

0db500d

Rollup merge of #143604 - nxsaken:const_float_round_methods, r=RalfJung Stabilize `const_float_round_methods` Closes #141555, waiting for FCP.

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025

Rollup merge of rust-lang#143604 - nxsaken:const_float_round_methods,…

9489d5b

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

apiraino removed the to-announce Announce this issue on triage meeting label Jul 24, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 29, 2025

Rollup merge of rust-lang#143604 - nxsaken:const_float_round_methods,…

716cc45

… r=RalfJung Stabilize `const_float_round_methods` Closes rust-lang#141555, waiting for FCP.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize `const_float_round_methods` #143604

Stabilize `const_float_round_methods` #143604

Uh oh!

nxsaken commented Jul 7, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 7, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 7, 2025

Uh oh!

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as resolved.

This comment was marked as resolved.

traviscross commented Jul 9, 2025

Uh oh!

rfcbot commented Jul 9, 2025 •

edited by joshtriplett

Loading

Uh oh!

rfcbot commented Jul 19, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

Uh oh!

Uh oh!

Stabilize const_float_round_methods #143604

Stabilize const_float_round_methods #143604

Uh oh!

Conversation

nxsaken commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 7, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 7, 2025

Uh oh!

Uh oh!

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as resolved.

This comment was marked as resolved.

traviscross commented Jul 9, 2025

Uh oh!

rfcbot commented Jul 9, 2025 • edited by joshtriplett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 19, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

RalfJung commented Jul 19, 2025

Uh oh!

bors commented Jul 19, 2025

Uh oh!

Uh oh!

Uh oh!

Stabilize `const_float_round_methods` #143604

Stabilize `const_float_round_methods` #143604

nxsaken commented Jul 7, 2025 •

edited

Loading

rfcbot commented Jul 9, 2025 •

edited by joshtriplett

Loading