Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 16, 2025

1 commits in eabb4cd923deb73e714f7ad3f5234d68ca284dbe..6833aa715d724437dc1247d0166afe314ab6854e
2025-07-09 22:07:55 +0000 to 2025-07-13 02:25:52 +0000

@ehuss ehuss self-assigned this Jul 16, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@ehuss
Copy link
Contributor Author

ehuss commented Jul 16, 2025

@bors r+ p=2

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit 10bc064 has been approved by ehuss

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
@bors
Copy link
Collaborator

bors commented Jul 16, 2025

⌛ Testing commit 10bc064 with merge f21fbac...

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing f21fbac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2025
@bors bors merged commit f21fbac into rust-lang:master Jul 16, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 16, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 231257f (parent) -> f21fbac (this PR)

Test differences

Show 9 test diffs

Stage 2

  • hints::empty_hints_no_warn: [missing] -> pass (J0)
  • hints::hint_unknown_type_warn: [missing] -> pass (J0)
  • hints::hints_mostly_unused_nightly: [missing] -> ignore (-Zhint-mostly-unused is unstable) (J0)
  • hints::hints_mostly_unused_warn_without_gate: [missing] -> pass (J0)
  • hints::mostly_unused_profile_overrides_hints_nightly: [missing] -> ignore (-Zhint-mostly-unused is unstable) (J0)
  • hints::mostly_unused_profile_overrides_hints_on_self_nightly: [missing] -> ignore (-Zhint-mostly-unused is unstable) (J0)
  • hints::unknown_hints_warn: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f21fbac535ab2c3bc50db20547f4d48477357103 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-msvc-2: 7111.3s -> 4518.3s (-36.5%)
  2. x86_64-msvc-2: 10509.8s -> 6871.1s (-34.6%)
  3. x86_64-apple-2: 5458.5s -> 3900.6s (-28.5%)
  4. x86_64-msvc-1: 12517.6s -> 8949.0s (-28.5%)
  5. aarch64-msvc-1: 8850.3s -> 6341.5s (-28.3%)
  6. dist-aarch64-msvc: 7575.2s -> 5546.6s (-26.8%)
  7. pr-check-1: 1727.2s -> 1519.5s (-12.0%)
  8. pr-check-2: 2636.0s -> 2327.9s (-11.7%)
  9. x86_64-gnu-llvm-20-1: 3641.1s -> 3217.8s (-11.6%)
  10. x86_64-apple-1: 7537.7s -> 6674.6s (-11.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f21fbac): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.6% [-3.6%, -3.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.6% [-3.6%, -3.6%] 1

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 466.648s -> 465.569s (-0.23%)
Artifact size: 374.71 MiB -> 374.85 MiB (0.04%)

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
Update cargo

1 commits in eabb4cd923deb73e714f7ad3f5234d68ca284dbe..6833aa715d724437dc1247d0166afe314ab6854e
2025-07-09 22:07:55 +0000 to 2025-07-13 02:25:52 +0000
- Add `[hints]` table in `Cargo.toml`, and a `hints.mostly-unused` hint (rust-lang/cargo#15673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants