Skip to content

A couple small changes for rust-analyzer next-solver work #145009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A couple small changes for rust-analyzer next-solver work #145009

wants to merge 2 commits into from
+30 −12

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Aug 6, 2025

Originally written by @flodiebold

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
@compiler-errors
Copy link
Member

r=me after fixing the merge conflict

@rust-cloud-vms rust-cloud-vms bot force-pushed the ra-next-solver-changes branch from e9b6d66 to 6296ca3 Compare August 6, 2025 18:36
@jackh726
Copy link
Member Author

jackh726 commented Aug 6, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit 6296ca3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the ra-next-solver-changes branch from 6296ca3 to a8f6528 Compare August 6, 2025 19:43
@jackh726
Copy link
Member Author

jackh726 commented Aug 6, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit a8f6528 has been approved by compiler-errors

It is now in the queue for this repository.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge of rust-lang#145009 - jackh726:ra-next-solver-changes, r…
63ca855 
…=compiler-errors

A couple small changes for rust-analyzer next-solver work

Originally written by `@flodiebold`
@Zalathar Zalathar mentioned this pull request Aug 7, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge of rust-lang#145009 - jackh726:ra-next-solver-changes, r…
bc3a3a5 
…=compiler-errors

A couple small changes for rust-analyzer next-solver work

Originally written by ``@flodiebold``
@Zalathar Zalathar mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jackh726 @rustbot @compiler-errors @bors @rust-log-analyzer @SparrowLii @flodiebold