GVN: Do not flatten derefs with ProjectionElem::Index. #145030
+153
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
Oof, that's subtle. Thanks for fixing this so quickly. @bors r+ |
bors
added
S-waiting-on-bors
cjgillot
force-pushed
the
gvn-no-flatten-index
branch
from
0f7f574 to
ebd60b9
Compare
|
Added a missing mir-opt test output. |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 8, 2025
…aethlin GVN: Do not flatten derefs with ProjectionElem::Index. r? `@saethlin` This should fix the bug you found with rust-lang#131650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @saethlin
This should fix the bug you found with #131650