Skip to content

Correctly handle when there are no unstable items in the documented crate #145349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correctly handle when there are no unstable items in the documented crate #145349

wants to merge 1 commit into from
+3 −1

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 13, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 13, 2025
Open
@fmease
Copy link
Member

fmease commented Aug 13, 2025 •
edited
Loading

Just curious, is there any more minimal way to reproduce the bug locally?

@GuillaumeGomez
Copy link
Member Author

I couldn't find one. It's very frustrating.

@fmease
Copy link
Member

fmease commented Aug 13, 2025 •
edited
Loading

I'm wondering if it would be something like "document crate X with an old rustdoc version, then redocument it with a new rustdoc version" in such way that the generated *.js files in doc/ aren't overwritten. Of course, we would never be able to turn this into a test.

@GuillaumeGomez
Copy link
Member Author

We always link to the right JS files, so I don't think it would trigger it (just tested and I confirm it didn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught DOMException: String contains an invalid character on nightly-rustc docs search
4 participants
@GuillaumeGomez @rustbot @fmease @notriddle