Skip to content

Windows: Replace GetThreadId+GetCurrentThread with GetCurrentThreadId #145412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Windows: Replace GetThreadId+GetCurrentThread with GetCurrentThreadId #145412

wants to merge 1 commit into from
+3 −3

Conversation

tgross35
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

ChrisDenton is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2025
@tgross35
Copy link
Contributor Author

@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 15, 2025
@rust-bors
Auto merge of #145412 - tgross35:win-tid, r=<try>
f87270a 
Windows: Replace `GetThreadId`+`GetCurrentThread` with `GetCurrentThreadId`

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor Author

@bors2 try cancel

@rust-bors
Copy link

rust-bors bot commented Aug 15, 2025

Try build cancelled. Cancelled workflows:

@tgross35
Copy link
Contributor Author

@bors2 try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 15, 2025
@rust-bors
Auto merge of #145412 - tgross35:win-tid, r=<try>
13665f6 
Windows: Replace `GetThreadId`+`GetCurrentThread` with `GetCurrentThreadId`
ChrisDenton
ChrisDenton approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. r=me when CI is green

@rust-bors
Copy link

rust-bors bot commented Aug 15, 2025

☀️ Try build successful (CI)
Build commit: 13665f6 (13665f6f7ddecd650058ae2c6aa5172cb8f6e28d, parent: 898aff704d6f0d00343f21d31b8b9bfac8e43007)

@tgross35
Copy link
Contributor Author

Thanks!

@bors r=ChrisDenton

@bors
Copy link
Collaborator

bors commented Aug 15, 2025

📌 Commit 2355563 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees

@ChrisDenton ChrisDenton

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tgross35 @rustbot @rust-log-analyzer @bors @ChrisDenton