Add some conversion trait impls #145504
Open
Add some conversion trait impls #145504
+96
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
7 tasks
This comment has been minimized.
This comment has been minimized.
Jules-Bertholet
force-pushed
the
more_conversion_trait_impls
branch
from
7ef29d9 to
3a96604
Compare
This comment has been minimized.
This comment has been minimized.
Jules-Bertholet
force-pushed
the
more_conversion_trait_impls
branch
from
3a96604 to
676ff1f
Compare
- `impl AsRef<str> for AsciiChar` (unstable) - `impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N]` - `impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]>` - `impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>` - `impl<T> AsRef<[Cell<T>]> for Cell<[T]>`
Jules-Bertholet
force-pushed
the
more_conversion_trait_impls
branch
from
676ff1f to
bd960c9
Compare
|
r? libs-api |
clarfonthey
reviewed
Aug 17, 2025
clarfonthey
reviewed
Aug 17, 2025
rustbot
added
the
T-libs
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 5, 2025
…r=<try> Add some conversion trait impls
rustbot
added
the
I-libs-api-nominated
tgross35
reviewed
Sep 5, 2025
Comment on lines
+1181
to
+1190
| impl AsMut<str> for AsciiChar { | ||
| #[inline(always)] | ||
| fn as_mut(&mut self) -> &mut str { | ||
| let ascii_ptr: *mut [Self] = crate::slice::from_mut(self); | ||
| let str_ptr = ascii_ptr as *mut str; | ||
| // SAFETY: Each ASCII codepoint in UTF-8 is encoded as one single-byte | ||
| // code unit having the same value as the ASCII byte. | ||
| unsafe { &mut *str_ptr } | ||
| } | ||
| } |
There was a problem hiding this comment.
This could probably be implemented in a new as_mut_str method, similar to as_str
Also, could everything here use #[inline] without the always?
tgross35
removed
the
S-waiting-on-review
tgross35
added
the
S-waiting-on-team
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl AsRef<str> for AsciiChar(unstable, cc Tracking Issue forascii::Char(ACP 179) #110998)impl AsMut<str> for AsciiChar(unstable, cc Tracking Issue forascii::Char(ACP 179) #110998)impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]>(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]>(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N](cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]>(equivalent ofas_array_of_cells, cc Tracking Issue for Cell::as_array_of_cells #88248)impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>impl<T> AsRef<[Cell<T>]> for Cell<[T]>(equivalent ofas_slice_of_cells)@rustbot label T-libs-api needs-fcp -T-libs
I’ve tried to only add impls that are unlikely to cause single-applicable-impl inference breakage.