Add some conversion trait impls #145504

Jules-Bertholet · 2025-08-16T16:22:58Z

impl AsRef<str> for AsciiChar (unstable, cc Tracking Issue for ascii::Char (ACP 179) #110998)
impl AsMut<str> for AsciiChar (unstable, cc Tracking Issue for ascii::Char (ACP 179) #110998)
impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]> (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]> (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]> (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]> (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]> (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N] (cc Tracking Issue for MaybeUninit methods for arrays #96097)
impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]> (equivalent of as_array_of_cells, cc Tracking Issue for Cell::as_array_of_cells #88248)
impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>
impl<T> AsRef<[Cell<T>]> for Cell<[T]> (equivalent of as_slice_of_cells)

@rustbot label T-libs-api needs-fcp -T-libs

I’ve tried to only add impls that are unlikely to cause single-applicable-impl inference breakage.

rustbot · 2025-08-16T16:23:03Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-08-17T01:49:17Z

r? libs-api

library/core/src/mem/maybe_uninit.rs

tgross35 · 2025-09-05T01:52:20Z

Preparing for crater

@bors try

@rustbot label +I-libs-api-nominated
r? libs

…r=<try> Add some conversion trait impls

tgross35 · 2025-09-05T02:47:42Z

library/core/src/ascii/ascii_char.rs

+impl AsMut<str> for AsciiChar {
+    #[inline(always)]
+    fn as_mut(&mut self) -> &mut str {
+        let ascii_ptr: *mut [Self] = crate::slice::from_mut(self);
+        let str_ptr = ascii_ptr as *mut str;
+        // SAFETY: Each ASCII codepoint in UTF-8 is encoded as one single-byte
+        // code unit having the same value as the ASCII byte.
+        unsafe { &mut *str_ptr }
+    }
+}


This could probably be implemented in a new as_mut_str method, similar to as_str

Also, could everything here use #[inline] without the always?

rust-bors · 2025-09-05T04:08:35Z

☀️ Try build successful (CI)
Build commit: 0498c15 (0498c157964e0946754e29e57ee9ef4527dc2a42, parent: af00ff2ce62b6617ed19305ae39e135ac71d0b22)

tgross35 · 2025-09-05T04:09:22Z

@craterbot check

craterbot · 2025-09-05T04:09:49Z

👌 Experiment pr-145504 created and queued.
🤖 Automatically detected try build 0498c15
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-08T21:32:36Z

🚧 Experiment pr-145504 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-10T11:53:18Z

🎉 Experiment pr-145504 is completed!
📊 1 regressed and 3 fixed (694485 total)
📊 1752 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-145504/retry-regressed-list.txt ↩

Jules-Bertholet · 2025-09-10T12:58:12Z

That 1 regression seems spurious.

bors · 2025-09-13T08:31:15Z

☔ The latest upstream changes (presumably #146494) made this pull request unmergeable. Please resolve the merge conflicts.

- `impl AsRef<str> for AsciiChar` (unstable) - `impl AsMut<str> for AsciiChar` (unstable) - `impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N]` - `impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]>` - `impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>` - `impl<T> AsRef<[Cell<T>]> for Cell<[T]>`

rustbot · 2025-09-14T15:39:24Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joshtriplett · 2025-09-23T15:49:45Z

We talked about these in today's @rust-lang/libs-api meeting.

The ones that stuck out to us were the impl AsRef<str> for AsciiChar and impl AsMut<str> for AsciiChar. Those seem correct, but we didn't see those specifically proposed anywhere, and it seemed odd to us to have impls for AsciiChar but not [AsciiChar] or [AsciiChar; N].

Could you elaborate on these, and point to where they might have been discussed? Was there a discussion of those specifically, or are you just proposing them because Char::as_str exists? If so, given that [Char]::as_str also exists, could you please provide the corresponding traits consistently for arrays/slices of Char?

joshtriplett · 2025-09-23T15:49:51Z

cc @the8472 for potential additional questions/comments.

Jules-Bertholet · 2025-09-24T01:40:31Z

Could you elaborate on these, and point to where they might have been discussed? Was there a discussion of those specifically, or are you just proposing them because Char::as_str exists?

Yes.

If so, given that [Char]::as_str also exists, could you please provide the corresponding traits consistently for arrays/slices of Char?

Unfortunately, alloc fails to build (“type annotations needed”) when I do that.

rustbot assigned Mark-Simulacrum Aug 16, 2025

Jules-Bertholet mentioned this pull request Aug 16, 2025

Tracking Issue for MaybeUninit methods for arrays #96097

Open

7 tasks

This comment has been minimized.

Sign in to view

Jules-Bertholet force-pushed the more_conversion_trait_impls branch from 7ef29d9 to 3a96604 Compare August 16, 2025 17:22

This comment has been minimized.

Sign in to view

Jules-Bertholet force-pushed the more_conversion_trait_impls branch 2 times, most recently from 676ff1f to bd960c9 Compare August 16, 2025 18:13

rustbot assigned m-ou-se and unassigned Mark-Simulacrum Aug 17, 2025

clarfonthey reviewed Aug 17, 2025

View reviewed changes

library/core/src/mem/maybe_uninit.rs Outdated Show resolved Hide resolved

clarfonthey reviewed Aug 17, 2025

View reviewed changes

library/core/src/mem/maybe_uninit.rs Outdated Show resolved Hide resolved

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 5, 2025

rustbot assigned tgross35 Sep 5, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 5, 2025

Auto merge of #145504 - Jules-Bertholet:more_conversion_trait_impls, …

0498c15

…r=<try> Add some conversion trait impls

rustbot unassigned m-ou-se Sep 5, 2025

rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 5, 2025

tgross35 reviewed Sep 5, 2025

View reviewed changes

tgross35 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2025

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Sep 5, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 10, 2025

Jules-Bertholet force-pushed the more_conversion_trait_impls branch from 8804742 to 5785a90 Compare September 14, 2025 15:39

Add some conversion trait impls #145504

Are you sure you want to change the base?

Add some conversion trait impls #145504

Conversation

Jules-Bertholet commented Aug 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Aug 17, 2025

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

tgross35 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Sep 5, 2025

Uh oh!

tgross35 commented Sep 5, 2025

Uh oh!

craterbot commented Sep 5, 2025

Uh oh!

craterbot commented Sep 8, 2025

Uh oh!

craterbot commented Sep 10, 2025

Footnotes

Uh oh!

Jules-Bertholet commented Sep 10, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

rustbot commented Sep 14, 2025

Uh oh!

joshtriplett commented Sep 23, 2025

Uh oh!

joshtriplett commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jules-Bertholet commented Sep 24, 2025

Uh oh!

Uh oh!

Jules-Bertholet commented Aug 16, 2025 •

edited

Loading

tgross35 commented Sep 5, 2025 •

edited

Loading

joshtriplett commented Sep 23, 2025 •

edited

Loading