Rollup of 5 pull requests #146494

jdonszelmann · 2025-09-13T00:40:47Z

Successful merges:

Convert no_std and no_core to the new attribute infrastructure #146389 (Convert no_std and no_core to the new attribute infrastructure)
sort array trait implementation suggestions correctly #146403 (sort array trait implementation suggestions correctly)
Improve alloc::Layout coverage #146452 (Improve alloc::Layout coverage)
Improve core::char coverage #146477 (Improve core::char coverage)
Improve core::hash coverage #146481 (Improve core::hash coverage)

r? @ghost
@rustbot modify labels: rollup

Convert `no_std` and `no_core` to the new attribute infrastructure r? ```@oli-obk``` Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

…-dead sort array trait implementation suggestions correctly Fixes rust-lang#135098. Previously tried in rust-lang#137428.

…rage, r=tgross35 Improve `alloc::Layout` coverage This PR improves the `core::alloc` coverage by adding a new test to `coretests` that cover the `Layout` methods when they error. Tracking issue: rust-lang#55724

…age, r=Noratrieb Improve `core::char` coverage This PR improves the `core::char` coverage by adding new tests to `coretests` r? ``@workingjubilee``

…age, r=jhpratt Improve `core::hash` coverage This PR improves the `core::hash` coverage by adding a new test to `coretests` and extending one of the existing tests to use 128-bit integers r? libs

jdonszelmann · 2025-09-13T00:41:03Z

@bors r+ p=5 rollup=never

bors · 2025-09-13T00:41:06Z

📌 Commit ec0f3bd has been approved by jdonszelmann

It is now in the queue for this repository.

bors · 2025-09-13T04:21:47Z

⌛ Testing commit ec0f3bd with merge 9642c0e...

bors · 2025-09-13T07:23:23Z

☀️ Test successful - checks-actions
Approved by: jdonszelmann
Pushing 9642c0e to master...

rust-timer · 2025-09-13T07:24:50Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#146389	Convert `no_std` and `no_core` to the new attribute infrast…	`573e5651ef6ca07c4167c8a3cef54a707bb56c1f` (link)
#146403	sort array trait implementation suggestions correctly	`14df85348e8466766b9f6e3e99edb29c35258194` (link)
#146452	Improve `alloc::Layout` coverage	`55da88b753c62a3fcc50deebd4186869f1b93738` (link)
#146477	Improve `core::char` coverage	`f13a1d78fa7c4614f270a03f6b2806cb69412ab4` (link)
#146481	Improve `core::hash` coverage	`a63f62f397056ff82a53b436f4bf88a63f7d18a1` (link)

previous master: 4ba1cf9ade

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-13T07:26:56Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4ba1cf9 (parent) -> 9642c0e (this PR)

Test differences

Show 20 test diffs

Stage 1

alloc::layout_errors: [missing] -> pass (J0)
char::test_as_ascii_invalid: [missing] -> pass (J0)
char::test_encode_utf16_raw_buffer_too_small: [missing] -> pass (J0)
char::test_encode_utf8_raw_buffer_too_small: [missing] -> pass (J0)
char::test_from_digit_invalid_radix: [missing] -> pass (J0)
char::test_from_digit_radix_too_high: [missing] -> pass (J0)
char::test_to_digit_radix_too_high: [missing] -> pass (J0)
char::test_to_digit_radix_too_low: [missing] -> pass (J0)
[ui] tests/ui/attributes/malformed-no-std.rs: [missing] -> pass (J3)

Stage 2

alloc::layout_errors: [missing] -> pass (J1)
char::test_as_ascii_invalid: [missing] -> pass (J1)
char::test_encode_utf16_raw_buffer_too_small: [missing] -> pass (J1)
char::test_encode_utf8_raw_buffer_too_small: [missing] -> pass (J1)
char::test_from_digit_invalid_radix: [missing] -> pass (J1)
char::test_from_digit_radix_too_high: [missing] -> pass (J1)
char::test_to_digit_radix_too_high: [missing] -> pass (J1)
char::test_to_digit_radix_too_low: [missing] -> pass (J1)
[ui] tests/ui/attributes/malformed-no-std.rs: [missing] -> pass (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9642c0ef6749e57ce76ac153807df1cc38cd26ee --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 7048.5s -> 5937.7s (-15.8%)
x86_64-gnu-llvm-19: 2427.8s -> 2792.5s (15.0%)
dist-apple-various: 4174.4s -> 3632.1s (-13.0%)
i686-gnu-2: 5386.2s -> 6067.7s (12.7%)
x86_64-gnu-llvm-19-3: 6207.9s -> 6975.5s (12.4%)
x86_64-rust-for-linux: 2540.8s -> 2842.4s (11.9%)
aarch64-gnu: 6240.1s -> 6929.3s (11.0%)
aarch64-gnu-llvm-19-1: 3249.3s -> 3567.7s (9.8%)
dist-x86_64-apple: 7952.3s -> 7209.2s (-9.3%)
x86_64-gnu-tools: 3332.0s -> 3633.7s (9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-13T08:33:25Z

Finished benchmarking commit (9642c0e): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-1.1%, -0.3%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[1.4%, 2.8%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -7.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.3%	[-8.6%, -4.2%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.868s -> 467.368s (-0.32%)
Artifact size: 388.08 MiB -> 388.09 MiB (0.00%)

jdonszelmann and others added 12 commits September 9, 2025 15:16

port #[no_core] to the new attribute parsing infrastructure

b262cae

port #[no_std] to the new attribute parsing infrastructure

0db2eb7

fixup no_{core,std} handling code

dbd3ef1

sort array trait implementation suggestions correctly

889be78

Improve core::alloc coverage

18059a0

Improve core::char coverage

51e3b62

Improve core::hash coverage

79643ad

Rollup merge of rust-lang#146389 - jdonszelmann:no-std, r=oli-obk

147e97a

Convert `no_std` and `no_core` to the new attribute infrastructure r? ```@oli-obk``` Also added a test for these, since we didn't have any and I was kind of surprised new diagnostics didn't break anything hehe

Rollup merge of rust-lang#146403 - cyrgani:array-sugg-sorting, r=fee1…

5dd5264

…-dead sort array trait implementation suggestions correctly Fixes rust-lang#135098. Previously tried in rust-lang#137428.

Rollup merge of rust-lang#146452 - ferrocene:pvdrz/improve-alloc-cove…

e4dbbbd

…rage, r=tgross35 Improve `alloc::Layout` coverage This PR improves the `core::alloc` coverage by adding a new test to `coretests` that cover the `Layout` methods when they error. Tracking issue: rust-lang#55724

Rollup merge of rust-lang#146477 - ferrocene:pvdrz/improve-char-cover…

7928be0

…age, r=Noratrieb Improve `core::char` coverage This PR improves the `core::char` coverage by adding new tests to `coretests` r? ``@workingjubilee``

Rollup merge of rust-lang#146481 - ferrocene:pvdrz/improve-hash-cover…

ec0f3bd

…age, r=jhpratt Improve `core::hash` coverage This PR improves the `core::hash` coverage by adding a new test to `coretests` and extending one of the existing tests to use 128-bit integers r? libs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2025

bors merged commit 9642c0e into rust-lang:master Sep 13, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 13, 2025

bors mentioned this pull request Sep 13, 2025

Add #[rustc_pass_indirectly_in_non_rustic_abis] #144529

Open

This was referenced Sep 13, 2025

Add some conversion trait impls #145504

Open

Stabilize char_max_len #145610

Open

initial implementation of the darwin_objc unstable feature #145660

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #146494

Rollup of 5 pull requests #146494

Uh oh!

jdonszelmann commented Sep 13, 2025 •

edited by rustbot

Loading

Uh oh!

jdonszelmann commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 13, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 13, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #146494

Rollup of 5 pull requests #146494

Uh oh!

Conversation

jdonszelmann commented Sep 13, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

bors commented Sep 13, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 13, 2025

Uh oh!

github-actions bot commented Sep 13, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 13, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

jdonszelmann commented Sep 13, 2025 •

edited by rustbot

Loading