Skip to content

Manual rollup of 19 pull requests #145545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 52 commits into from
Closed

Manual rollup of 19 pull requests #145545

wants to merge 52 commits into from

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Aug 17, 2025 •
edited by rustbot
Loading

Note: This is a manual rollup. bors is acting up and the queue is large, so this is the next best thing.

Included PRs:

r? @ghost

Kixunil and others added 30 commits May 13, 2025 23:41
@Kixunil
impl PartialEq<{str,String}> for {Path,PathBuf}
aab1563 
Comparison of paths and strings is expected to be possible and needed
e.g. in tests. This change adds the impls os `PartialEq` between strings
and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151
@GrigorenkoPV
Stabilize ip_from
964eb82
@WaffleLapkin
refactor unreachable/expr_cast.rs test
a067c6a
@WaffleLapkin
don't warn on explicit casts of never to any
d2e133d
@Kivooeo
updated doc comment
970ac40
@Zalathar
Use LLVMSetTailCallKind
c64c6d8
@scrabsha
Port #[custom_mir(..)] to the new attribute system
51bccdd
@bjorn3
All weak lang items have an explicit link name and vice versa
4d62bf1
@bjorn3
Combining no_mangle and rustc_std_internal_symbol is not allowed
f3ef465
@Zalathar
Use LLVMGetTypeKind
e193b53
@bjorn3
Merge link_name and export_name
460519a
@bjorn3
Remove unused feature gate
f94a0d0
@WaffleLapkin
add static glibc to the nix dev shell
1d00627 
this fixes `tests/ui/process/nofile-limit.rs` which fails to link on
nixos for me without this change
@alurm
Fix typo in doc for library/std/src/fs.rs#set_permissions
9fab380 
"privalage" -> "privilege"
@Kobzol
Do not call fs::remove_file in cp_link_filtered_recurse
5107ac9 
The target is removed by `copy_link` too, so no need to duplicate the syscall.
@Kobzol
Optimize copy_src_dirs
cdea62d
@JonathanBrouwer
Don't show foreign types as an allowed target if the feature is not e…
e8f90b1 
…nabled
@JonathanBrouwer
Fix deprecation attribute on foreign statics & types
a69ba29
@jdonszelmann
take attr style into account in attr diagnostics
70e26c1
@Urgau
Fix unicode_data.rs mention message
e906a59
@fee1-dead
remove should_render in PrintAttribute derive
3450975
@lolbinarycat
run spellcheck as a tidy extra check in ci
e31fed0
@cjgillot
Simplify decode_span.
6c15339
@cjgillot
Simplify span_data_to_lines_and_cols.
a843730
@lolbinarycat
tidy now installs typos-cli as-needed via cargo
1cb4fd7
@lolbinarycat
tidy: run typos check in src root, not current dir
6a51eef
@lolbinarycat
tidy: add better error reporting for if typos can't be run
d73e6b4
@lolbinarycat
typos: allow moreso
0d797d2
@lolbinarycat
std: fix more typos
2050a3b
@GuillaumeGomez
Fix bug where rustdoc-js tester would not pick the right `search.js…
80d3234 
…` file if there is more than one
@jhpratt jhpratt added the rollup A PR which is a rollup label Aug 17, 2025
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

tidy extra checks were modified.

cc @lolbinarycat

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Aug 17, 2025

⚠️ Warning ⚠️

@jhpratt
Copy link
Member Author

jhpratt commented Aug 17, 2025

Given the odd nature of this, I'm doing a try build before merging.

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Aug 17, 2025

⌛ Trying commit cbc4330 with merge 4176766…

To cancel the try build, run the command @bors try cancel.

rust-bors bot added a commit that referenced this pull request Aug 17, 2025
@rust-bors
Auto merge of #145545 - jhpratt:manual-rollup, r=<try>
4176766 
Manual rollup of 19 pull requests
@jhpratt
Copy link
Member Author

jhpratt commented Aug 17, 2025

@bors2 try cancel

Bors is working long enough to create a proper rollup. Running with that.

@jhpratt jhpratt closed this Aug 17, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2025
@rust-bors
Copy link

rust-bors bot commented Aug 17, 2025

Try build cancelled. Cancelled workflows:

@jhpratt jhpratt deleted the manual-rollup branch August 17, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.