Rollup of 12 pull requests #145860

jhpratt · 2025-08-25T21:10:35Z

Successful merges:

Port #[link] to the new attribute parsing infrastructure #143193 (Port #[link] to the new attribute parsing infrastructure )
remove deprecated Error::description in impls #144373 (remove deprecated Error::description in impls)
Implement some more checks in ptr_guaranteed_cmp. #144885 (Implement some more checks in ptr_guaranteed_cmp. )
make rustdoc::invalid_html_tags more robust #145535 (make rustdoc::invalid_html_tags more robust)
test(rustfmt): Verify frontmatter is preserved #145766 (test(rustfmt): Verify frontmatter is preserved)
Fix some minor issues in comments #145811 (Fix some minor issues in comments)
Handle unwinding fatal errors in codegen workers #145814 (Handle unwinding fatal errors in codegen workers)
Wait for DPkg frontend lock when trying to remove packages #145815 (Wait for DPkg frontend lock when trying to remove packages)
compiletest: if a compiler fails, show its output #145821 (compiletest: if a compiler fails, show its output)
Make x test distcheck self-contained #145845 (Make x test distcheck self-contained)
Don't show warnings from xcrun with -Zverbose-internals #145847 (Don't show warnings from xcrun with -Zverbose-internals)
Update books #145856 (Update books)

r? @ghost
@rustbot modify labels: rollup

This is to prove that the frontmatter is preserved. The choices in tests is intended for showing the different parts of the proposed Style Guide for frontmatters.

previously, this lint did not distinguish between `<img` and `<img>`, and since the latter should be accepted under html5, the former was also accepted. the parser now also handles multi-line tags and multi-line attributes.

Pointers with different residues modulo their least common allocation alignment are never equal. Pointers to the same static allocation are equal if and only if they have the same offset. Strictly in-bounds (in-bounds and not one-past-the-end) pointers to different static allocations are always unequal. A pointer cannot be equal to an integer if `ptr-int` cannot be null. Also adds more tests for `ptr_guaranteed_cmp`. Co-authored-by: Ralf Jung <post@ralfj.de>

All function pointers are currently treated as unaligned anyway; any change implementing function pointer alignment during consteval should add tests that it works properly on arm::t32 functions.

Signed-off-by: houpo-bob <houpocun@outlook.com>

As opposed to passing it around through Result.

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

These kinds of warnings can make our test suites fail, so if we want them, we'll need a different flag.

…nszelmann Port `#[link]` to the new attribute parsing infrastructure Ports `link` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

…=RalfJung Implement some more checks in `ptr_guaranteed_cmp`. * Pointers with different residues modulo their allocations' least common alignment are never equal. * Pointers to the same static allocation are equal if and only if they have the same offset. * Pointers to different non-zero-sized static allocations are unequal if both point within their allocation, and not on opposite ends. Tracking issue for `const_raw_ptr_comparison`: <rust-lang#53020> This should not affect `is_null`, the only usage of this intrinsic on stable. Closes rust-lang#144584

…tags-svg-145529, r=GuillaumeGomez make rustdoc::invalid_html_tags more robust best reviewed a commit at a time. I kept finding more edge case so I ended up having to make quite significant changes to the parser in order to make it preserve state across events and handle multiline attributes correctly. fixes rust-lang#145529

test(rustfmt): Verify frontmatter is preserved This is to prove that the frontmatter is preserved. The choices in tests is intended for showing the different parts of the proposed Style Guide for frontmatters (rust-lang#145617). While rustfmt is developed in a different repo, work involving upstream integration is blocked on some work that is being finished up in that repo. I was told that it would be ok to post against this repo in the mean time. Tracking issue: rust-lang#136889

Fix some minor issues in comments Fix some minor issues in comments

… r=petrochenkov Handle unwinding fatal errors in codegen workers Also directly unwind on fatal errors at the point they are emitted inside the codegen backends. Fixes the coordinator ICE of rust-lang#132240, rust-lang#135075 and rust-lang#145800.

…ieni Wait for DPkg frontend lock when trying to remove packages Hopefully this helps with [#t-infra > pr-check-1 fails on "free up disk space"](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/pr-check-1.20fails.20on.20.22free.20up.20disk.20space.22/with/535794424). As suggested by riking in [#t-infra > pr-check-1 fails on "free up disk space" @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/pr-check-1.20fails.20on.20.22free.20up.20disk.20space.22/near/535791579), thanks! r? infra-ci

…w, r=clubby789 compiletest: if a compiler fails, show its output Before, when working on something like a `rustdoc-js` test, if you made a syntax error in a rust file, you would not get that error output unless you ran with `--verbose`, which would also cause an enormous amount of other output to be printed as well. This can also lead to frustration in new contributors who don't think to run with `--verbose`. Now, if rustc or rustdoc is run by compiletest and produces an non-zero exit code, its output will be printed.

jhpratt · 2025-08-25T21:10:46Z

@bors r+ rollup=never p=5

bors · 2025-08-25T21:10:48Z

📌 Commit 838586a has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-08-25T21:56:47Z

⌛ Testing commit 838586a with merge 036a5ec...

Rollup of 12 pull requests Successful merges: - #143193 (Port `#[link]` to the new attribute parsing infrastructure ) - #144373 (remove deprecated Error::description in impls) - #144885 (Implement some more checks in `ptr_guaranteed_cmp`. ) - #145535 (make rustdoc::invalid_html_tags more robust) - #145766 (test(rustfmt): Verify frontmatter is preserved) - #145811 (Fix some minor issues in comments) - #145814 (Handle unwinding fatal errors in codegen workers) - #145815 (Wait for DPkg frontend lock when trying to remove packages) - #145821 (compiletest: if a compiler fails, show its output) - #145845 (Make `x test distcheck` self-contained) - #145847 (Don't show warnings from xcrun with -Zverbose-internals) - #145856 (Update books) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-08-25T22:54:57Z

The job dist-various-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] object test:false 5.648
warning: dropping unsupported crate type `dylib` for target `x86_64-fortanix-unknown-sgx`

error: unused import: `str`
 --> library/std/src/sys/pal/sgx/os.rs:7:22
  |
7 | use crate::{fmt, io, str};
  |                      ^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`

bors · 2025-08-25T22:55:30Z

💔 Test failed - checks-actions

jieyouxu · 2025-08-26T00:44:43Z

I believe this is #144373.
@bors r-

epage and others added 30 commits August 20, 2025 15:54

test(rustfmt): Verify frontmatter is preserved

b51a8ed

This is to prove that the frontmatter is preserved. The choices in tests is intended for showing the different parts of the proposed Style Guide for frontmatters.

add regression test for rust-lang#145529

e50fed7

refactor rustdoc::invalid_html_tags tag parser

15a8999

previously, this lint did not distinguish between `<img` and `<img>`, and since the latter should be accepted under html5, the former was also accepted. the parser now also handles multi-line tags and multi-line attributes.

rustdoc::invalid_html_tags(unclosed comment): fix off by one in span

d022089

Remove arm::t32-specific function pointer test.

25afbbc

All function pointers are currently treated as unaligned anyway; any change implementing function pointer alignment during consteval should add tests that it works properly on arm::t32 functions.

Fix some minor issues in comments

5d41f7c

Signed-off-by: houpo-bob <houpocun@outlook.com>

Handle unwinding fatal errors in codegen workers

46a7d28

Move NativeLibKind from rustc_session to rustc_hir

00fe7d1

Directly raise fatal errors inside the codegen backends

525c6a3

As opposed to passing it around through Result.

compiletest: if a compiler fails outside a ui test, show its output

9567812

remove deprecated Error::description in impls

78b8fdf

Port the #[link] attribute to the new parser

8533310

Changes to the uitests

ff053ba

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>

Make x test distcheck more self-contained

a3229e4

Handle tarballs in x test tidy

89f9cf3

Do not forward CI configure arguments to distcheck builds

8fa5fc6

Override GITHUB_ACTIONS=0 for tidy tests

2ea8621

Don't show warnings from xcrun with -Zverbose-internals

d262463

These kinds of warnings can make our test suites fail, so if we want them, we'll need a different flag.

Wait for DPkg frontend lock when trying to remove packages

cce9479

Update books

f43c6f9

Rollup merge of rust-lang#143193 - JonathanBrouwer:link_rework, r=jdo…

45b47c0

…nszelmann Port `#[link]` to the new attribute parsing infrastructure Ports `link` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

Rollup merge of rust-lang#144373 - hkBst:remove-deprecated-1, r=jhpratt

640d074

remove deprecated Error::description in impls [libs-api permission](rust-lang/libs-team#615 (comment)) r? `@cuviper` or `@jhpratt`

Rollup merge of rust-lang#145811 - houpo-bob:master, r=samueltardieu

b8fe5f5

Fix some minor issues in comments Fix some minor issues in comments

rustbot added the rollup A PR which is a rollup label Aug 25, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2025

jieyouxu mentioned this pull request Aug 26, 2025

remove deprecated Error::description in impls #144373

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2025

jieyouxu closed this Aug 26, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 26, 2025

jhpratt deleted the rollup-w1oo0ci branch August 26, 2025 04:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 12 pull requests #145860

Rollup of 12 pull requests #145860

Uh oh!

jhpratt commented Aug 25, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

rust-log-analyzer commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

jieyouxu commented Aug 26, 2025

Uh oh!

Uh oh!

Rollup of 12 pull requests #145860

Rollup of 12 pull requests #145860

Uh oh!

Conversation

jhpratt commented Aug 25, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

rust-log-analyzer commented Aug 25, 2025

Uh oh!

bors commented Aug 25, 2025

Uh oh!

jieyouxu commented Aug 26, 2025

Uh oh!

Uh oh!

jhpratt commented Aug 25, 2025 •

edited by rustbot

Loading