-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Stabilize fmt::from_fn
#145915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Stabilize fmt::from_fn
#145915
Conversation
r? libs-api |
☔ The latest upstream changes (presumably #146023) made this pull request unmergeable. Please resolve the merge conflicts. |
(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature. (2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out I would be thrilled to have someone with sufficient permissions start an FCP for |
I think that's true, but I was imagining that the FCP would just happen here.
I'd be fine with that - hopefully someone will start an FCP there. |
I'm closing this for now with the idea that the full feature will hopefully get FCP'd. |
5209f60
to
80851e7
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Resolves #146705, pending its FCP.
As discussed in that tracking issue and #117729, this splits
fmt::from_fn
out from thedebug_closure_helpers
feature.