Skip to content

Conversation

coolreader18
Copy link
Contributor

@coolreader18 coolreader18 commented Aug 27, 2025

Resolves #146705, pending its FCP.

As discussed in that tracking issue and #117729, this splits fmt::from_fn out from the debug_closure_helpers feature.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 27, 2025
@Kobzol
Copy link
Member

Kobzol commented Aug 27, 2025

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 27, 2025
@rustbot rustbot assigned m-ou-se and unassigned thomcc Aug 27, 2025
@bors
Copy link
Collaborator

bors commented Aug 30, 2025

☔ The latest upstream changes (presumably #146023) made this pull request unmergeable. Please resolve the merge conflicts.

@jmillikin
Copy link
Contributor

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I would be thrilled to have someone with sufficient permissions start an FCP for debug_closure_helpers.

@coolreader18
Copy link
Contributor Author

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

I think that's true, but I was imagining that the FCP would just happen here.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I'd be fine with that - hopefully someone will start an FCP there.

@coolreader18
Copy link
Contributor Author

I'm closing this for now with the idea that the full feature will hopefully get FCP'd.

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2025
@coolreader18 coolreader18 reopened this Sep 19, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] askama test:false 0.169
error[E0658]: use of unstable library feature `round_char_boundary`
   --> src/librustdoc/passes/lint/unescaped_backticks.rs:447:25
    |
447 |             ("...", dox.ceil_char_boundary(insert_index - context_before_max_len))
    |                         ^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #93743 <https://github.com/rust-lang/rust/issues/93743> for more information
    = help: add `#![feature(round_char_boundary)]` to the crate attributes to enable
    = note: this compiler was built on 2025-08-04; consider upgrading it if it is out of date

error[E0658]: use of unstable library feature `round_char_boundary`
   --> src/librustdoc/passes/lint/unescaped_backticks.rs:452:25
    |
452 |             ("...", dox.floor_char_boundary(insert_index + context_after_max_len))
    |                         ^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #93743 <https://github.com/rust-lang/rust/issues/93743> for more information
    = help: add `#![feature(round_char_boundary)]` to the crate attributes to enable
    = note: this compiler was built on 2025-08-04; consider upgrading it if it is out of date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for fmt_from_fn
8 participants