Rollup of 9 pull requests #146023
Merged
Rollup of 9 pull requests #146023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `SymInfo` stores a `Section`, which is just an index:
SymInfo {
section: Section(
SectionIndex(
539,
),
),
...
},
Look up and store the section name instead if possible, with a fallback
to the `Section` debug printing. This makes output more clear and will
allow us to filter by section name.
Since [1], our object files may now contain a GDB script section. These symbols wind up with multiple instances in the archive but are weak, so we can safely ignore them in our duplicates check. This resolves the current CI failures. [1]: rust-lang#143679
i128/u128 haven't flagged `improper_ctypes` for a while, and this just made it to stable [1]. Remove the `allow`s as they are no longer needed. [1]: https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#i128-and-u128-in-extern-c-functions
This target is currently build-only. Switch to the windows-11-arm runner, which allows us to start running tests.
This updates the rust-version file to ffb9d94.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: ffb9d94 Filtered ref: 2f31646593733abae36e4c05b5a54acfb9f1f6bc This merge was created using https://github.com/rust-lang/josh-sync.
Like `__real@`, and `__xmm@`, Windows can emit duplicate `__ymm@` symbols for constants.
LLVM does not currently emit these, but it is being discussed as an option on platforms where `f32` is not hardware supported. Glibc/libgcc also has the comparison functions [1] already. The generic implementations for addition, subtraction, and multiplication work for f16 without any complications, as do comparisons, so add them here. [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=6ec6c77867af4ddfec7323e0ac6ede89effca852
This updates the rust-version file to d36f964.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: d36f964 Filtered ref: 92461731ae79cfe5044e4826160665b77c0363a2 This merge was created using https://github.com/rust-lang/josh-sync.
We have a ui test to ensure we emit an error if we encounter too big enums. Before this fix, compiling the test with `-Cdebuginfo=2` would not include the span of the instantiation site, because the error is then emitted from a different code path that does not include the span. Propagate the span to the error also in the debuginfo case, so the test passes regardless of debuginfo level.
Android has supported pipe2 since 2010, long before the current min SDK.
…mulacrum std: use a TAIT to define `SplitPaths` on UNIX Defining `SplitPaths` as a TAIT allows using closures instead of function pointers for `split` and `map`.
…e_atomic_ptr, r=scottmcm Stabilize `strict_provenance_atomic_ptr` feature This closes [tracking issue](rust-lang#99108) and stabilises `AtomicPtr::{fetch_ptr_add, fetch_ptr_sub, fetch_byte_add, fetch_byte_sub, fetch_or, fetch_and, fetch_xor}` --- EDIT: FCP completed at rust-lang#99108 (comment)
…=scottmcm str: Stabilize `round_char_boundary` feature Closes rust-lang#93743 FCP completed rust-lang#93743 (comment)
…=wesleywiser compiler: Include span of too huge enum with `-Cdebuginfo=2` We have the ui test `tests/ui/limits/huge-enum.rs` to ensure we emit an error if we encounter too big enums. Before this fix, compiling the test with `-Cdebuginfo=2` would not include the span of the instantiation site, because the error is then emitted from a different code path that does not include the span. Propagate the span to the error also in the debuginfo case, so the test passes regardless of debuginfo level. I'm sure we can propagate spans in more places, but let's start small. ## Test failure without the fix Here is what the failure looks like if you run the test without the fix: ``` [ui] tests/ui/limits/huge-enum.rs#full-debuginfo ... F . failures: ---- [ui] tests/ui/limits/huge-enum.rs#full-debuginfo stdout ---- Saved the actual stderr to `/home/martin/src/rust/build/x86_64-unknown-linux-gnu/test/ui/limits/huge-enum.full-debuginfo/huge-enum.full-debuginfo.stderr` diff of stderr: 1 error: values of the type `Option<TYPE>` are too big for the target architecture - --> $DIR/huge-enum.rs:17:9 - | - LL | let big: BIG = None; - | ^^^ 6 7 error: aborting due to 1 previous error 8 The actual stderr differed from the expected stderr To update references, rerun the tests and pass the `--bless` flag To only update this specific test, also pass `--test-args limits/huge-enum.rs` ``` as can be seen, the `span` used to be missing with `debuginfo=2`. ## See also This is one small step towards resolving rust-lang#61117. cc rust-lang#144499 which began running UI tests with `rust.debuginfo-level-tests=1`. This PR is part of preparing for increasing that to debuglevel 2.
`AutoDeref::final_ty` is already resolved What is a `bool` argument doing here :< The initial value is already resolved https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L130 For `builtin_deref` we assert that this is still the case https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L82 While `overloaded_deref_ty` also resolves at the end https://github.com/rust-lang/rust/blob/41f2b6b39e7526a28d50ff6918dda6de48add5e4/compiler/rustc_hir_analysis/src/autoderef.rs#L173
std: haiku: fix `B_FIND_PATH_IMAGE_PATH` Fixes rust-lang#145952, which was caused by rust-lang/libc#4575 ```````@rustbot``````` label T-libs O-haiku
…vement, r=notriddle Improve librustdoc error when a file creation/modification failed The message before looks like this: ``` failed to create or modify "/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/search.index/entry/" ``` And with this change it looks like this: ``` failed to create or modify "/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/search.index/entry/": failed to read column from disk: data consumer error: missing field `unknown number` at line 1 column 8 ``` r? ``````@lolbinarycat``````
Mark pipe2 supported in Android Android has supported pipe2 since 2010, long before the current min SDK.
compiler-builtins subtree update Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@ac3a4cd. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
rustbot
added
A-compiler-builtins
rustbot
added
O-unix
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: fe55364329 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing fe55364 (parent) -> e004014 (this PR) Test differencesShow 676 test diffsStage 1
Stage 2
Additionally, 670 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e004014d1bf4c29928a0f0f9f7d0964d43606cbd --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (e004014): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -4.9%, secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 467.034s -> 467.673s (0.14%) |
This was referenced Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
SplitPathson UNIX #145242 (std: use a TAIT to defineSplitPathson UNIX)strict_provenance_atomic_ptrfeature #145467 (Stabilizestrict_provenance_atomic_ptrfeature)round_char_boundaryfeature #145756 (str: Stabilizeround_char_boundaryfeature)-Cdebuginfo=2#145967 (compiler: Include span of too huge enum with-Cdebuginfo=2)AutoDeref::final_tyis already resolved #145990 (AutoDeref::final_tyis already resolved)B_FIND_PATH_IMAGE_PATH#145991 (std: haiku: fixB_FIND_PATH_IMAGE_PATH)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup