-
Notifications
You must be signed in to change notification settings - Fork 13.7k
changes for vxworks #146073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
changes for vxworks #146073
Conversation
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@@ -21,7 +21,7 @@ macro_rules! or_panic { | |||
} | |||
|
|||
#[test] | |||
#[cfg_attr(target_os = "android", ignore)] // Android SELinux rules prevent creating Unix sockets | |||
#[cfg_attr(any(target_os = "vxworks", target_os = "android"), ignore)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make these look like this, with some reasoning for why this test is ignored on vxworks (is there a fundamental reason, is it just not implemented yet, etc)?
#[cfg_attr(any(target_os = "vxworks", target_os = "android"), ignore)] | |
#[cfg_attr(target_os = "android", ignore = "Android SELinux rules prevent creating Unix sockets")] | |
#[cfg_attr(target_os = "vxworks", ignore = "...")] |
#[cfg(all(not(target_os = "vxworks"),unix))] | ||
error!(result, "Not a directory"); | ||
#[cfg(target_os = "vxworks")] | ||
error!(result, "not a directory"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cleaner as a cfg_select!
, e.g.
#[cfg(all(not(target_os = "vxworks"),unix))] | |
error!(result, "Not a directory"); | |
#[cfg(target_os = "vxworks")] | |
error!(result, "not a directory"); | |
cfg_select! { | |
target_os = "vxworks" => { | |
error!(result, "not a directory"); | |
} | |
unix => { | |
error!(result, "Not a directory"); | |
} | |
windows => { | |
error!(result, 267); // ERROR_DIRECTORY - The directory name is invalid. | |
} | |
_ => { | |
// all good. | |
} | |
} |
This description restates in four different ways that it improves vxworks support, but gives no indication of what it changes or why that is. Please make sure it’s easy for reviewers to understand what is going on, even “Ignore X-related tests that currently fail on VxWorks” is more useful. Pinging target maintainer @biabbas for review |
Summary
This PR improves support for the
vxworks
target in the Rust standard library by fixing platform-specific issues and ensuring better compatibility with VxWorks.These changes are isolated to
vxworks
and do not affect other platforms.Notes
Tested manually on a VxWorks environment. Feedback on potential edge cases or additional tests would be appreciated.