Rollup of 5 pull requests #146282

tgross35 · 2025-09-06T18:39:07Z

Successful merges:

Add socket extensions for cygwin #139524 (Add socket extensions for cygwin)
single buffer for exponent fmt of integers #145940 (single buffer for exponent fmt of integers)
identity uses are ok, even if there are no defining uses #146206 (identity uses are ok, even if there are no defining uses)
Update comment for -Werror on LLVM builds #146272 (Update comment for -Werror on LLVM builds)
Make LetChainsPolicy public for rustfmt usage #146280 (Make LetChainsPolicy public for rustfmt usage)

r? @ghost
@rustbot modify labels: rollup

… MSVC definitively excluded

…oss35 Add socket extensions for cygwin r? `@joboet` * Abstract name uds addr * quickack * passcred

single buffer for exponent fmt of integers No need for fragmented buffers when formatting. ``` orig.txt: fmt::write_i128_exp 143.39ns/iter +/- 0.32 orig.txt: fmt::write_i64_exp 68.72ns/iter +/- 0.03 new.txt: fmt::write_i128_exp 138.29ns/iter +/- 0.50 new.txt: fmt::write_i64_exp 58.93ns/iter +/- 4.62 ``` This patch fully eliminates unsafe pointer use (after rust-lang#135265 and rust-lang#136594). r? libs

identity uses are ok, even if there are no defining uses fix rust-lang#146191 I've tried moving the "is this an identity use" check to `fn clone_and_resolve_opaque_types` and this would allow the following code to compile as it now ignores `Opaque<'!a> = Opaque<'!a>` while they previously resulted in errors https://github.com/rust-lang/rust/blob/71289c378d0a406a4f537fe4001282d19362931f/tests/ui/type-alias-impl-trait/hkl_forbidden.rs#L42-L46 The closure signature gets inferred to `for<'a> fn(&'a ()) -> Inner<'a>`. The closure then has a defining use `Inner<'a_latbound> = &'a_latebound ()` while the parent function has a non-defining `Inner<'!a> = Inner<'!a>`. By eagerly discarding identity uses we don't error on the non-defining use in the parent. r? `@BoxyUwU`

…ommment_llvm22, r=tgross35 Update comment for `-Werror` on LLVM builds cc rust-lang#109712 see rust-lang#109712 (comment)

… r=lqd Make `LetChainsPolicy` public for rustfmt usage Related to rust-lang#138511. To call `Parser::parse_expr_cond` from [rustfmt forks for custom macro formatting](https://github.com/tucant/rustfmt/blob/30c83df9e1db10007bdd16dafce8a86b404329b2/src/parse/macros/html.rs#L57) you need to pass this enum so it would be nice if it could be public. Thank you.

tgross35 · 2025-09-06T18:39:15Z

@bors r+ rollup=never p=5

bors · 2025-09-06T18:39:18Z

📌 Commit f338542 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-09-06T21:48:01Z

⌛ Testing commit f338542 with merge 76863e3...

bors · 2025-09-07T01:03:50Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 76863e3 to master...

rust-timer · 2025-09-07T01:05:17Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#139524	Add socket extensions for cygwin	`572793b77c9c213db35358027a554c34949ba8e8` (link)
#145940	single buffer for exponent fmt of integers	`2557331400bd6dd86dd185daca7ec8a3de692bd5` (link)
#146206	identity uses are ok, even if there are no defining uses	`9b8b6fb5b5c272f47db02c74afae913f2fe5a942` (link)
#146272	Update comment for `-Werror` on LLVM builds	`efbec9e3428563f89c6e6320a530c9e4034754ec` (link)
#146280	Make `LetChainsPolicy` public for rustfmt usage	`65cb9d6d53a508b4a4e123bda655632ecd3e7709` (link)

previous master: 1ed3cd7030

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-09-07T01:07:12Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1ed3cd7 (parent) -> 76863e3 (this PR)

Test differences

Show 173 test diffs

Stage 1

[ui] tests/ui/impl-trait/non-defining-uses/ice-issue-146191.rs#current: [missing] -> pass (J0)
[ui] tests/ui/impl-trait/non-defining-uses/ice-issue-146191.rs#next: [missing] -> pass (J0)
fmt::write_i128_exp: [missing] -> pass (J3)
fmt::write_i64_exp: [missing] -> pass (J3)

Stage 2

fmt::write_i128_exp: [missing] -> pass (J1)
fmt::write_i64_exp: [missing] -> pass (J1)
[ui] tests/ui/impl-trait/non-defining-uses/ice-issue-146191.rs#current: [missing] -> pass (J2)
[ui] tests/ui/impl-trait/non-defining-uses/ice-issue-146191.rs#next: [missing] -> pass (J2)

Additionally, 165 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 76863e340416e7f21955bdaf0ae9728eb51f5671 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3321.7s -> 3938.3s (18.6%)
arm-android: 5583.3s -> 6378.3s (14.2%)
pr-check-1: 1371.6s -> 1509.8s (10.1%)
dist-riscv64-linux: 4787.8s -> 5230.2s (9.2%)
dist-aarch64-msvc: 6097.9s -> 5540.7s (-9.1%)
i686-gnu-1: 7285.0s -> 7931.5s (8.9%)
dist-x86_64-apple: 7372.2s -> 8001.6s (8.5%)
x86_64-msvc-ext1: 7229.1s -> 7821.9s (8.2%)
dist-powerpc64le-linux-gnu: 5662.9s -> 5222.9s (-7.8%)
x86_64-gnu-tools: 3342.0s -> 3601.3s (7.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-07T03:32:44Z

Finished benchmarking commit (76863e3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.1%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.747s -> 466.57s (0.18%)
Artifact size: 387.43 MiB -> 387.43 MiB (-0.00%)

pascaldekloe and others added 11 commits August 22, 2025 17:40

benchmarks for exponent fmt of integers

2143a3f

single buffer for exponent fmt of integers

56e95aa

Add socket extensions for cygwin

26b1575

identity uses are ok, even if there are no defining uses

381b326

Update comment for werror on rust-lang/rust CI explaining why we keep…

6c4e958

… MSVC definitively excluded

Make LetChainsPolicy public for rustfmt usage

7fada16

Rollup merge of rust-lang#139524 - Berrysoft:cygwin-socket-ext, r=tgr…

31d7cbc

…oss35 Add socket extensions for cygwin r? `@joboet` * Abstract name uds addr * quickack * passcred

Rollup merge of rust-lang#146272 - rperier:rustc_llvm_werror_remove_c…

865c99a

…ommment_llvm22, r=tgross35 Update comment for `-Werror` on LLVM builds cc rust-lang#109712 see rust-lang#109712 (comment)

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2025

bors merged commit 76863e3 into rust-lang:master Sep 7, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 7, 2025

tgross35 deleted the rollup-0n5tjnm branch September 7, 2025 01:21

bors mentioned this pull request Sep 7, 2025

changes for vxworks #146073

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #146282

Rollup of 5 pull requests #146282

Uh oh!

tgross35 commented Sep 6, 2025 •

edited by rustbot

Loading

Uh oh!

tgross35 commented Sep 6, 2025

Uh oh!

bors commented Sep 6, 2025

Uh oh!

bors commented Sep 6, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Sep 7, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #146282

Rollup of 5 pull requests #146282

Uh oh!

Conversation

tgross35 commented Sep 6, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Sep 6, 2025

Uh oh!

bors commented Sep 6, 2025

Uh oh!

bors commented Sep 6, 2025

Uh oh!

bors commented Sep 7, 2025

Uh oh!

Uh oh!

rust-timer commented Sep 7, 2025

Uh oh!

github-actions bot commented Sep 7, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Sep 7, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

tgross35 commented Sep 6, 2025 •

edited by rustbot

Loading