rustdoc-search: add test case for indexing every item type #146131
+171
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-run-make
notriddle
added
T-rustdoc
rustbot
added
the
T-rustdoc-frontend
This comment has been minimized.
This comment has been minimized.
|
Okay, so it reproduces #t-rustdoc > Impossible to run GUI tests: search index creation fails @ 💬 in CI. Now, if I rebase, it should pass. |
notriddle
force-pushed
the
rustdoc-search-load-itemtype-test
branch
from
7d4f91a to
3fb91f1
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
GuillaumeGomez
approved these changes
Sep 2, 2025
|
Nice, thanks! r=me once CI pass. |
notriddle
force-pushed
the
rustdoc-search-load-itemtype-test
branch
from
3fb91f1 to
dd8df3b
Compare
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 3, 2025
…type-test, r=GuillaumeGomez rustdoc-search: add test case for indexing every item type Test case for rust-lang#146117
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 3, 2025
…type-test, r=GuillaumeGomez rustdoc-search: add test case for indexing every item type Test case for rust-lang#146117
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 3, 2025
…type-test, r=GuillaumeGomez rustdoc-search: add test case for indexing every item type Test case for rust-lang#146117
bors
added a commit
that referenced
this pull request
Sep 3, 2025
Rollup of 9 pull requests Successful merges: - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146120 (Correct typo in `rustc_errors` comment) - #146131 (rustdoc-search: add test case for indexing every item type) r? `@ghost` `@rustbot` modify labels: rollup
|
Failed on a platform that can't build proc macros #146147 (comment) |
bors
added
S-waiting-on-author
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 3, 2025
…type-test, r= rustdoc-search: add test case for indexing every item type Test case for rust-lang#146117
bors
added a commit
that referenced
this pull request
Sep 3, 2025
Rollup of 15 pull requests Successful merges: - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146120 (Correct typo in `rustc_errors` comment) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146133 (Revert "Make `lto` and `linker-plugin-lto` work the same for `compiler_builtins`) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) r? `@ghost` `@rustbot` modify labels: rollup
|
Failed in rollup in @bors r- |
This bug only shows up when you run htmldocck in a directory other than outdir, and also use globs. Never happened before, which is why we're only seeing it now.
notriddle
force-pushed
the
rustdoc-search-load-itemtype-test
branch
from
dd8df3b to
fcc413f
Compare
|
@bors r=GuillaumeGomez Exclude cross-compiling and target platforms that can't do proc macros. |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case for #146117