Skip to content

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 7, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

kumarUjjawal and others added 10 commits September 4, 2025 00:03
It is always false nowadays. ThinLTO summary writing is instead done by
llvm_optimize.
…crum

fix: offline rustdoc html missing favicon

As discussed in the rust-lang#146149 the doc was missing the favicon icon when build locally and viewed on a browser. I changed the relative path and also now we explicitly copy both SVG and PNG.

<img width="1132" height="425" alt="Screenshot 2025-09-03 at 11 57 46 PM" src="https://github.com/user-attachments/assets/062cbb08-04ec-4d88-a43a-710fb6190f82" />
Misc LTO cleanups

Follow up to rust-lang#145955.

* Remove want_summary argument from `prepare_thin`.
   Since rust-lang#133250 ThinLTO summary writing is instead done by `llvm_optimize`.
* Two minor cleanups
…mulacrum

feat(std): emulate flock for solaris via fcntl

Upstream Solaris flock emulation to libstd from cargo.

This is borrowed from
https://github.com/rust-lang/cargo/blob/3b379fcc541b39321a7758552d37e5e0cc4277b9/src/cargo/util/flock.rs#L502-L536 which was implemented by an Oracle employee.
The code has been in cargo since 2022-12.

Python's `fcntl.flock` emulates like this as well: https://github.com/python/cpython/blob/c919d02edecfe9d75fe374756fb8aa1db8d95f55/Modules/fcntlmodule.c#L337-L400

We did the same thing in
https://github.com/rust-lang/rust/blob/0d0f4eac8b98133e5da6d3604d86a8f3b5a67844/compiler/rustc_data_structures/src/flock/unix.rs#L13-L39

However, should we just always falls back to fcntl for all Unix, instead of "unsupported"?

try-job: `*-solaris`
…ethlin

Introduce PlaceContext::may_observe_address.

A small utility method to avoid open-coding the logic in several MIR opts.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 7, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 36557d1 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@bors
Copy link
Collaborator

bors commented Sep 7, 2025

⌛ Testing commit 36557d1 with merge 12eb345...

bors added a commit that referenced this pull request Sep 7, 2025
Rollup of 4 pull requests

Successful merges:

 - #146170 (fix: offline rustdoc html missing favicon)
 - #146209 (Misc LTO cleanups)
 - #146269 (feat(std): emulate flock for solaris via fcntl)
 - #146297 (Introduce PlaceContext::may_observe_address.)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants