Quieter tidy #146316
Quieter tidy #146316
Conversation
rustbot
added
A-testsuite
|
I think the first two commits should be uncontroversial, because they are about individual tidy checks that are noisy. The third one I'm less sure about, because it's removing top-level tidy progress indicators. |
| @@ -95,7 +95,6 @@ fn check_removed_error_code_explanation(ci_info: &crate::CiInfo, bad: &mut bool) | |||
| eprintln!("Take a look at E0001 to see how to handle it."); | |||
| return; | |||
| } | |||
| println!("No error code explanation was removed!"); | |||
There was a problem hiding this comment.
These messages are useful, especially in regression checks later on if this code because outdated (ie, how error codes are handled changed).
| @@ -16,7 +15,6 @@ pub fn check(src_path: &Path, ci_info: &crate::CiInfo, bad: &mut bool) { | |||
| // First we check that `src/rustdoc-json-types` was modified. | |||
| if !crate::files_modified(ci_info, |p| p == RUSTDOC_JSON_TYPES) { | |||
| // `rustdoc-json-types` was not modified so nothing more to check here. | |||
| println!("`rustdoc-json-types` was not modified."); | |||
|
I also agree that the messages that say that something was checked are quite useful, because tidy actually has a lot of optional functionality ( What I think we could improve though is the error message when something bad actually happens, because that is sometimes a bit drowned in the rest of the text. So the errors should BE LOUD AND VISIBLE, so that you can always quickly find out if an error happened or not. Maybe tidy also say something like "everything was fine" at the very end, ideally printed in green, to help us figure out if the result was ok or not. |
|
If you have a message per step, I think I'd slightly prefer to have "Checking x..." at the start of the step than have "x is good" at the end of the step. |
|
Well, I guess my intution about this is off. |
rustbot
removed
the
S-waiting-on-review
When I run
tidyI currently get output like this:Several of these output lines seem unnecessary. E.g. there are lots of different tidy tests, why do a couple of them print output saying that they don't need to do anything?
r? @GuillaumeGomez