Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/bootstrap/src/core/build_steps/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,6 @@ impl Step for Tidy {

if builder.config.channel == "dev" || builder.config.channel == "nightly" {
if !builder.config.json_output {
builder.info("fmt check");
if builder.config.initial_rustfmt.is_none() {
let inferred_rustfmt_dir = builder.initial_sysroot.join("bin");
eprintln!(
Expand Down Expand Up @@ -1277,10 +1276,8 @@ HELP: to skip test's attempt to check tidiness, pass `--skip src/tools/tidy` to
}
}

builder.info("tidy check");
cmd.delay_failure().run(builder);

builder.info("x.py completions check");
let completion_paths = get_completion_paths(builder);
if builder.config.cmd.bless() {
builder.ensure(crate::core::build_steps::run::GenerateCompletions);
Expand Down
1 change: 0 additions & 1 deletion src/tools/tidy/src/error_codes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ fn check_removed_error_code_explanation(ci_info: &crate::CiInfo, bad: &mut bool)
eprintln!("Take a look at E0001 to see how to handle it.");
return;
}
println!("No error code explanation was removed!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages are useful, especially in regression checks later on if this code because outdated (ie, how error codes are handled changed).

}

/// Stage 1: Parses a list of error codes from `error_codes.rs`.
Expand Down
2 changes: 0 additions & 2 deletions src/tools/tidy/src/rustdoc_json.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use std::str::FromStr;
const RUSTDOC_JSON_TYPES: &str = "src/rustdoc-json-types";

pub fn check(src_path: &Path, ci_info: &crate::CiInfo, bad: &mut bool) {
println!("Checking tidy rustdoc_json...");
let Some(base_commit) = &ci_info.base_commit else {
eprintln!("No base commit, skipping rustdoc_json check");
return;
Expand All @@ -16,7 +15,6 @@ pub fn check(src_path: &Path, ci_info: &crate::CiInfo, bad: &mut bool) {
// First we check that `src/rustdoc-json-types` was modified.
if !crate::files_modified(ci_info, |p| p == RUSTDOC_JSON_TYPES) {
// `rustdoc-json-types` was not modified so nothing more to check here.
println!("`rustdoc-json-types` was not modified.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

return;
}
// Then we check that if `FORMAT_VERSION` was updated, the `Latest feature:` was also updated.
Expand Down
Loading