Update the arm-* and aarch64-* platform docs. #146419
Conversation
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The Rust Embedded Devices Working Group (wg-embedded) Arm Team (t-arm) agreed to listed as maintainers of: * aarch64-unknown-none * aarch64-unknown-none-softfloat * armv7a-none-eabi * armv7r-none-eabi * armv7r-none-eabihf The aarch64-unknown-none* target didn't have a page so I added it. wg-embedded t-arm did not want to take over: * armebv7r-none-eabi * armebv7r-none-eabihf So I gave them their own target page. The current maintainer remains.
thejpster
force-pushed
the
update-arm-target-docs
branch
from
8a54175 to
faf0e14
Compare
|
Force-pushed with fixed markdown formatting. |
This comment has been minimized.
This comment has been minimized.
thejpster
force-pushed
the
update-arm-target-docs
branch
from
827e2cd to
f1abb70
Compare
This comment has been minimized.
This comment has been minimized.
|
r? @workingjubilee maybe? |
|
|
| ## Start-up and Low-Level Code | ||
|
|
||
| The [Rust Embedded Devices Working Group Arm Team] maintain the | ||
| [`aarch64-cpu`], which may be useful for writing bare-metal code using this |
There was a problem hiding this comment.
the aarch64-cpu... what?
I think you mean "crate", or you mean to delete the "the" from the previous line.
|
|
||
| ```toml | ||
| [target.<your-target>] | ||
| linker = "arm-none-eabi-ld" |
There was a problem hiding this comment.
This does not seem to be the right linker name for aarch64 targets?
| processor supports a different set of floating-point features than the default | ||
| expectations of `fp-armv8`, then these should also be enabled or disabled as | ||
| needed with `-C target-feature=(+/-)`. For example, | ||
| `-Ctarget-feature=+neon-fp-armv8`. |
There was a problem hiding this comment.
Doesn't this need a comma?
| `-Ctarget-feature=+neon-fp-armv8`. | |
| `-Ctarget-feature=+neon,-fp-armv8`. |
There was a problem hiding this comment.
Fair point. I'll remove the example, as I don't think it's actually helpful.
|
|
||
| ## Target maintainers | ||
|
|
||
| * [@chrisnc](https://github.com/chrisnc) |
There was a problem hiding this comment.
Uhm. Hrm.
@chrisnc Do you assent?
@thejpster I am not sure I have seen an assent by Chris to maintain this specific target variant.
There was a problem hiding this comment.
The armebv7r and armv7r targets were on the same page, and so I concluded Chris was the maintainer for both. Pretty sure he wrote the page back in 90893e4.
https://doc.rust-lang.org/beta/rustc/platform-support/armv7r-none-eabi.html
rustbot
added
S-waiting-on-author
This PR updates some of the arm*-unknown-none target docs, and adds some missing target pages.
aarch64-none-elf and aarch64-none-elf-softfloat
The Rust Embedded Devices Working Group's Arm Team is added as a maintainer, and a target page is added. Links are added to the EDWG's support crates for this target.
armv7a-none-eabi and armv7a-none-eabihf
The Rust Embedded Devices Working Group's Arm Team is added as a maintainer, and a target page is added. Links are added to the EDWG's support crates for this target.
armv7r-none-eabi and armv7r-none-eabihf
The Rust Embedded Devices Working Group's Arm Team is added as a maintainer, and the target page is split from the Big Endian versions. Links are added to the EDWG's support crates for this target.
armebv7r-none-eabi and armveb7r-none-eabihf
The target page is split from the Little Endian versions. No change in maintainers.
I have agreement to add EDWG/T-Arm as maintainers, which was voted upon in their repo.