-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Promote armv8r-none-eabihf target to Tier 2 #146520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thejpster
wants to merge
11
commits into
rust-lang:master
Choose a base branch
from
thejpster:promote-armv8r-none-eabi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+265
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust Embedded Devices Working Group (wg-embedded) Arm Team (t-arm) agreed to listed as maintainers of: * aarch64-unknown-none * aarch64-unknown-none-softfloat * armv7a-none-eabi * armv7r-none-eabi * armv7r-none-eabihf The aarch64-unknown-none* target didn't have a page so I added it. wg-embedded t-arm did not want to take over: * armebv7r-none-eabi * armebv7r-none-eabihf So I gave them their own target page. The current maintainer remains.
Removes a bunch of information that isn't, strictly speaking, target specific.
This is important to note, as it affects how easy it is to build a binary, and that `#![no_std]` is mandatory. A different PR should probably add this to all the other platform pages.
This is the target for supporting Arm Cortex-R52 bare-metal systems, which are common in safety-critical systems.
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
rustbot has assigned @petrochenkov. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes armv8r-none-eabihf to Tier 2, joining armv7r-none-eabi, armv7r-none-eabihf and armv7a-none-eabi.
This PR wil be rebased once #146419 completes the queue.
The
armv8r-none-eabihf
target is for the Arm Cortex-R52 processor, as found in a number of Automotive SoCs that have just been released, or are about to be released. Currently SoCs are available from NXP and Renesas.The Embedded Devices Working Group's Arm Team have just started maintaining this target.
This target is highly similar to a number of existing Tier 2 targets, including
armv7r-none-eabihf
and so it should not add undue burden.https://doc.rust-lang.org/nightly/rustc/platform-support/armv8r-none-eabihf.html exists and was updated in #146419
I believe it does.
The Armv8-R architecture introduces a new FPU type, the fp-armv8, and so this requires a unique target.
It has a full libcore, as per the other arm*-none-* targets.
It should be the same backend as
armv7r-none-eabihf
and friends, except for FPU support, which is already covered inthumbv8m.main-none-eabihf
. There are no issues that I know of.The ABI is EABI, the same as many other Arm targets.
The https://github.com/rust-embedded/cortex-ar repository regularly builds this target with
-Zbuild-std=core
and it seems fine.There are no no-std tests in the tree that I'm aware of.
Building libcore is quite fast.
It does.
Just libcore required (and liballoc). No known issues here.
Noted
The https://github.com/rust-embedded/cortex-ar repository will be changed to use the rustup component when available.
Noted