Skip to content

fix ./x readdir logic when CDPATH is set #146777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2025
Merged

fix ./x readdir logic when CDPATH is set #146777

merged 1 commit into from
Sep 20, 2025
+2 −1

Conversation

RalfJung
Copy link
Member

Fixes #146769
r? @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 19, 2025
@Kobzol
Copy link
Member

Kobzol commented Sep 19, 2025

Thanks. Hopefully it won't break anyone.. I hope that macOS always has /dev/null, lol.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 19, 2025

📌 Commit 04f6b8f has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 19, 2025
@matthiaskrgr
Rollup merge of rust-lang#146777 - RalfJung:x-cdpath, r=Kobzol
4cab322 
fix ./x readdir logic when CDPATH is set

Fixes rust-lang#146769
r? `@Kobzol`
This was referenced Sep 19, 2025
Closed
Merged
bors added a commit that referenced this pull request Sep 19, 2025
@bors
Auto merge of #146797 - matthiaskrgr:rollup-xy0g8n7, r=matthiaskrgr
ec38671 
Rollup of 5 pull requests

Successful merges:

 - #146690 (add `[const] PartialEq` bound to `PartialOrd`)
 - #146776 (fixes for numerous clippy warnings)
 - #146777 (fix ./x readdir logic when CDPATH is set)
 - #146781 (mbe: Fix feature gate for `macro_derive`)
 - #146785 (btree: safety comments for init and new)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dc3c62a into rust-lang:master Sep 20, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 20, 2025
rust-timer added a commit that referenced this pull request Sep 20, 2025
@rust-timer
Unrolled build for #146777
67d3881 
Rollup merge of #146777 - RalfJung:x-cdpath, r=Kobzol

fix ./x readdir logic when CDPATH is set

Fixes #146769
r? ``@Kobzol``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

Invoking x from a parent directory fails when CDPATH is set
4 participants
@RalfJung @Kobzol @bors @rustbot