Skip to content

Rollup of 5 pull requests #146797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 20, 2025
Merged

Rollup of 5 pull requests #146797

merged 10 commits into from
Sep 20, 2025
+37 −34

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Sep 19, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

npmccallum and others added 10 commits September 17, 2025 16:39
@npmccallum
add [const] PartialEq bound to PartialOrd
8d7ec96 
This change is included for discussion purposes.

The PartialOrd bound on PartialEq is not strictly necessary. It
is, rather, logical: anything which is orderable should by
definition have equality. Is the same true for constness? Should
every type which is const orderable also have const equality?
@hkBst
fixes for numerous clippy warnings
e500dd8
@RalfJung
fix ./x readdir logic when CDPATH is set
04f6b8f
@joshtriplett
mbe: Fix feature gate for macro_derive
3ab89ab
@hkBst
btree: safety comments for init and new
e2de670
@matthiaskrgr
Rollup merge of rust-lang#146690 - npmccallum:convo, r=tgross35
96a4ae3 
add `[const] PartialEq` bound to `PartialOrd`

This change is included for discussion purposes.

The PartialOrd bound on PartialEq is not strictly necessary. It is, rather, logical: anything which is orderable should by definition have equality. Is the same true for constness? Should every type which is const orderable also have const equality?
@matthiaskrgr
Rollup merge of rust-lang#146776 - hkBst:clippy-fix-12, r=jdonszelmann
29f3942 
fixes for numerous clippy warnings
@matthiaskrgr
Rollup merge of rust-lang#146777 - RalfJung:x-cdpath, r=Kobzol
dc3c62a 
fix ./x readdir logic when CDPATH is set

Fixes rust-lang#146769
r? ``@Kobzol``
@matthiaskrgr
Rollup merge of rust-lang#146781 - joshtriplett:mbe-derive-fix-featur…
02faee6 
…e-gate, r=wesleywiser

mbe: Fix feature gate for `macro_derive`
@matthiaskrgr
Rollup merge of rust-lang#146785 - hkBst:btree-1, r=joboet
6f9e6c9 
btree: safety comments for init and new
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 19, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 19, 2025

📌 Commit 6f9e6c9 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025
@bors
Copy link
Collaborator

bors commented Sep 19, 2025

⌛ Testing commit 6f9e6c9 with merge ec38671...

@bors
Copy link
Collaborator

bors commented Sep 20, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ec38671 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2025
@bors bors merged commit ec38671 into rust-lang:master Sep 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 20, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146690 add [const] PartialEq bound to PartialOrd 95ce7485881fc8b93085043e6cbc831cbb214269 (link)
#146776 fixes for numerous clippy warnings d7e9f76250130055e72342d64c1dd312b5c60334 (link)
#146777 fix ./x readdir logic when CDPATH is set 67d38816f33534d5fb35c2c3efdf5bcf54f7ac3c (link)
#146781 mbe: Fix feature gate for macro_derive 3c5240bf1c80d5c9513af872a300a8e204c1c983 (link)
#146785 btree: safety comments for init and new 246608f23844f54018421fc9d5fa069669cce4c7 (link)

previous master: 0be8e16088

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0be8e16 (parent) -> ec38671 (this PR)

Test differences

Show 76 test diffs

76 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ec38671075266e9cee0348701da2e133379e7c6c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 4365.9s -> 5142.9s (17.8%)
  2. dist-aarch64-windows-gnullvm: 4707.0s -> 5398.6s (14.7%)
  3. aarch64-apple: 6397.4s -> 5485.9s (-14.2%)
  4. dist-aarch64-apple: 6660.7s -> 6123.4s (-8.1%)
  5. dist-x86_64-windows-gnullvm: 5093.2s -> 4688.0s (-8.0%)
  6. i686-gnu-2: 5351.8s -> 5710.0s (6.7%)
  7. aarch64-gnu-llvm-20-1: 3503.6s -> 3274.3s (-6.5%)
  8. x86_64-mingw-2: 8429.4s -> 7933.9s (-5.9%)
  9. dist-x86_64-musl: 7870.6s -> 7429.9s (-5.6%)
  10. dist-x86_64-apple: 7298.5s -> 7693.0s (5.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ec38671): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.625s -> 470.599s (-0.43%)
Artifact size: 389.93 MiB -> 389.97 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @bors @rust-timer @rustbot @npmccallum @hkBst @RalfJung @joshtriplett