Skip to content

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Oct 5, 2025

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 5, 2025

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 5, 2025

📌 Commit 7c8fe29 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
…eyouxu

update autodiff testcases

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler
bors added a commit that referenced this pull request Oct 5, 2025
Rollup of 3 pull requests

Successful merges:

 - #146874 (compiler: Hint at multiple crate versions if trait impl is for wrong ADT )
 - #147262 (Make #[link="dl"] an FCW rather than an error)
 - #147364 (update autodiff testcases)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 5, 2025
Rollup of 5 pull requests

Successful merges:

 - #144908 (Fix doctest output json)
 - #147262 (Make #[link="dl"] an FCW rather than an error)
 - #147364 (update autodiff testcases)
 - #147367 (Trivial code cleanup in resolve)
 - #147369 (Fill out AVR target metadata)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c840719 into rust-lang:master Oct 5, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 5, 2025
rust-timer added a commit that referenced this pull request Oct 5, 2025
Rollup merge of #147364 - ZuseZ4:update-autodiff-tests, r=jieyouxu

update autodiff testcases

unblock EnzymeAD/Enzyme#2430 (again).
Just as I landed a fix for the last test, this one broke. The test should now be fine if the name mangling hash changes again.

Also removed an outdated fixme that's not needed since moving autodiff to an intrinsic. The test currently just checks that it compiles, I'll add more precise checks once we actually run this in CI.

r? compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants