Skip to content

Trivial code cleanup in resolve #147367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Trivial code cleanup in resolve #147367

wants to merge 1 commit into from
+1 −5

Conversation

chenyukang
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

jieyouxu
jieyouxu approved these changes Oct 5, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Oct 5, 2025

r=me once PR CI is green.

@chenyukang
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Oct 5, 2025

📌 Commit 95445f9 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147367 - chenyukang:yukang-trivial-cleanup,…
94e0499 
… r=jieyouxu

Trivial code cleanup in resolve

r? `@jieyouxu`
@Zalathar Zalathar mentioned this pull request Oct 5, 2025
Open
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147371 - Zalathar:rollup-897uitw, r=Zalathar
bcbbdcb 
Rollup of 5 pull requests

Successful merges:

 - #144908 (Fix doctest output json)
 - #147262 (Make #[link="dl"] an FCW rather than an error)
 - #147364 (update autodiff testcases)
 - #147367 (Trivial code cleanup in resolve)
 - #147369 (Fill out AVR target metadata)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyukang @rustbot @jieyouxu @bors