Clippy subtree update #147405
Merged
Clippy subtree update #147405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autofix now: - includes the swapping of index and element in the closure in which the content will be consumed; - notes, with applicability `MaybeIncorrect` (because it will be), that the element and the index will be swapped.
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>
Renames InstantSubtraction to UncheckedTimeSubtraction
* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting
Clean up `ty::Dynamic` 1. As a follow-up to PR rust-lang#143036, remove `DynKind` entirely. 2. Inside HIR ty lowering, consolidate modules `dyn_compatibility` and `lint` into `dyn_trait` * `dyn_compatibility` wasn't about dyn compatibility itself, it's about lowering trait object types * `lint` contained dyn-Trait-specific diagnostics+lints only
refactored with `check_item` and `check_item_post`. this refactoring also fixed a few bugs related to mod path with shared segment name caused by preivous approach. changelog: [`self_named_module_files`]: don't lint mod tagged with path attribute changelog: [`mod_module_files`]: don't lint mod tagged with path attribute Signed-off-by: Zihan <zihanli0822@gmail.com>
and use it instead of clippy::only_used_in_recursion when the parameter in question is self.
* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting changelog: none
Missed update lints versions for 1.90 at rust-lang/rust-clippy#15670 so doing this changelog: none r? @flip1995
and use it instead of `clippy::only_used_in_recursion` when the parameter in question is self. Fixes rust-lang/rust-clippy#10370 changelog: [`only_used_in_recursion`]: Don't lint if parameter is `self`; add pedantic `self_only_used_in_recursion` lint.
The autofix now: - includes the swapping of index and element in the closure in which the content will be consumed; - notes, with applicability `MaybeIncorrect` (because it will be), that the element and the index will be swapped. changelog: [`range_zip_with_len`]: better suggestion, and better applicability Fixes rust-lang/rust-clippy#14929
rust-lang#15593) Fixes rust-lang/rust-clippy#9913 changelog: [`nonstandard_macro_braces`]: suggest trailing semicolon when needed
changelog: none
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>
all the lints work with `if`-expressions
rustbot
added
S-waiting-on-review
|
This comment has been minimized.
This comment has been minimized.
flip1995
force-pushed
the
clippy-subtree-update
branch
from
4583238 to
8c4be66
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-bootstrap
This comment has been minimized.
This comment has been minimized.
flip1995
force-pushed
the
clippy-subtree-update
branch
from
ef574f9 to
e652436
Compare
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
@bors r+ p=1 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3d8c1c1 (parent) -> 68ad253 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 68ad25392f6faf1af5d169bdd81c817521ad2c1d --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Oct 7, 2025
|
Finished benchmarking commit (68ad253): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.01s -> 473.761s (0.37%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? Manishearth
Cargo.lockupdate due totomlversion bump. This causedserde_corebeing added as a transitive dependency, sotidy --blesshad to be run.(Sorry for the late sync)