Fix target list of link_section
#147418
Merged
Fix target list of link_section
#147418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
This comment was marked as outdated.
This comment was marked as outdated.
|
@rustbot label beta-nominated |
rustbot
added
the
beta-nominated
|
Actually, would like to add a regression test for this |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
JonathanBrouwer
commented
Oct 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
I commented that above already, that's why it's waiting on author :) |
|
Oh sorry, I managed to read every other comment but missed that specific comment 😂 |
rustbot
added
S-waiting-on-review
|
|
jdonszelmann
reviewed
Oct 7, 2025
| | | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = help: `#[link_section]` can be applied to statics and functions | ||
| = help: `#[link_section]` can be applied to functions and statics |
There was a problem hiding this comment.
maybe we should sort this list in the future, so this doesn't happen
There was a problem hiding this comment.
better for incremental too actually hehe
|
yea this seems like something we missed during migration. Looking good, apart from link name on traits which I agree is weird |
bors
added
S-waiting-on-bors
|
@bors r- I guess the beta backport first should be accepted |
bors
added
S-waiting-on-author
|
r=me when it does |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 7, 2025
Rollup of 7 pull requests Successful merges: - #145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - #147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - #147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - #147418 (Fix target list of `link_section`) - #147429 (Print tip for human error format in runtest) - #147441 (Fix comments error for Provenance impls) - #147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 7, 2025
Rollup merge of #147418 - JonathanBrouwer:link_section_targets, r=jdonszelmann Fix target list of `link_section` Fixes #147411 (comment) r? `@jdonszelmann` `@rustbot` beta-nominate T-compiler
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Oct 8, 2025
…hanBrouwer sort attribute targets for more consistent error messages In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same. See: rust-lang#147418 (comment) I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously. r? `@jieyouxu`
rust-timer
added a commit
that referenced
this pull request
Oct 8, 2025
Rollup merge of #147445 - jdonszelmann:sort-targets, r=JonathanBrouwer sort attribute targets for more consistent error messages In this PR I noticed that we don't sort attribute targets, so a rather trivial change to the source changed the ordering in an error message even though its meaning stayed the same. See: #147418 (comment) I think sorting might be a good thing to do in general. I also prefer it when reading error messages. Quite a few tests changed, but not in meaning, only sorting order obviously. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147411 (comment)
r? @jdonszelmann
@rustbot beta-nominate T-compiler