Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 9, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

durin42 and others added 7 commits October 7, 2025 11:02
This avoids an extra trip through a triple string by directly passing
the Triple, and has been available since LLVM 21. The string overload
was deprecated today and throws an error on our CI for HEAD due to
-Werror paranoia, so we may as well clean this up now and also skip the
conversion on LLVM 21 since we can.

@rustbot label llvm-main
This is useful for ensuring that changes to compiletest haven't broken
rustdoc-gui-test.
…cation, r=Zalathar

PassWrapper: use non-deprecated lookupTarget method

This avoids an extra trip through a triple string by directly passing the Triple, and has been available since LLVM 21. The string overload was deprecated today and throws an error on our CI for HEAD due to -Werror paranoia, so we may as well clean this up now and also skip the conversion on LLVM 21 since we can.

`@rustbot` label llvm-main
…Kobzol

Do `x check` on various bootstrap tools in CI

These tools aren't included in a default `x check`, but checking them locally is still useful for maintainers working on the tools themselves:

- bootstrap
- bump-stage0
- compiletest
- coverage-dump
- linkchecker
- run-make-support
- rustdoc-gui-test

This PR therefore explicitly checks them in one CI job, to ensure that check builds for them continue to work.
… r=Zalathar

remove intrinsic wrapper functions from LLVM bindings

As discussed on llvm/llvm-project#162500 there is no good reason to implement these intrinsic function via the LLVM wrapper instead we now just implement them via `call_intrinsic` like all the other intrinsic functions.

Work towards rust-lang#46437
@rustbot rustbot added A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 9, 2025
@Zalathar
Copy link
Contributor Author

Zalathar commented Oct 9, 2025

Rollup of everything not in #147512.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

📌 Commit 828dd0c has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2025
@bors
Copy link
Collaborator

bors commented Oct 9, 2025

⌛ Testing commit 828dd0c with merge 4b57d81...

@bors
Copy link
Collaborator

bors commented Oct 9, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 4b57d81 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 9, 2025
@bors bors merged commit 4b57d81 into rust-lang:master Oct 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 9, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#147446 PassWrapper: use non-deprecated lookupTarget method c7563cef7d94e61da19de75961cfe07b27be2b8b (link)
#147473 Do x check on various bootstrap tools in CI 8f053add9e6a58126d90c25d18d7713be820d8ce (link)
#147509 remove intrinsic wrapper functions from LLVM bindings c13bfdabfaf5680378bdc66b823b81d67ced379d (link)

previous master: acf243778e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

github-actions bot commented Oct 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing acf2437 (parent) -> 4b57d81 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4b57d8154a6a74d2514cd3a674c1f29a588f224a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 8955.6s -> 7054.2s (-21.2%)
  2. pr-check-1: 1819.1s -> 1446.3s (-20.5%)
  3. dist-various-1: 4431.7s -> 3828.1s (-13.6%)
  4. x86_64-gnu-llvm-20: 2756.6s -> 2385.0s (-13.5%)
  5. i686-gnu-1: 8068.0s -> 7254.4s (-10.1%)
  6. x86_64-gnu-miri: 4799.3s -> 4316.9s (-10.1%)
  7. x86_64-gnu-tools: 3697.5s -> 3380.9s (-8.6%)
  8. arm-android: 6148.2s -> 5665.0s (-7.9%)
  9. dist-aarch64-apple: 8374.8s -> 7770.5s (-7.2%)
  10. aarch64-msvc-1: 7389.0s -> 6856.1s (-7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants