Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 11, 2025

This is an attempt to work around the CI failures at #147556, by using a later version of libffi-sys.

The newer version of libffi-sys incorporates a configure script generated by a newer version of autoconf, which should avoid an (artificial) incompatibility with uutils.

This newer version of libffi-sys incorporates a `configure` script generated by
a newer version of autoconf, which avoids an incompatibility with uutools.
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar

This comment was marked as resolved.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
Bump libffi-sys to 3.3.3 to avoid CI failure

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: aarch64-gnu-llvm=20
@rust-bors

This comment was marked as resolved.

@rust-log-analyzer

This comment was marked as resolved.

@Zalathar
Copy link
Contributor Author

@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
Bump libffi-sys to 3.3.3 to avoid CI failure

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: aarch64-gnu-llvm-20
@rust-bors

This comment was marked as resolved.

@rust-log-analyzer

This comment was marked as resolved.

@Zalathar
Copy link
Contributor Author

@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20-1,aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
Bump libffi-sys to 3.3.3 to avoid CI failure

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: aarch64-gnu-llvm-20-1
try-job: aarch64-gnu-llvm-20-2
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-debug failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  --- stderr
  clang: error: unsupported option '-print-multi-os-directory'
  clang: error: no input files
  config.status: error: in `/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-e9834bcb452f6870/out/libffi-build/aarch64-unknown-linux-gnu':
  config.status: error: Something went wrong bootstrapping makefile fragments
      for automatic dependency tracking.  If GNU make was not used, consider
      re-running the configure script with MAKE="gmake" (or whatever is
      necessary).  You can also try re-running configure with the
      '--disable-dependency-tracking' option to at least be able to build
      the package (albeit without support for automatic dependency tracking).
  See `config.log' for more details

  thread 'main' (98681) panicked at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/libffi-sys-3.3.3/build/not_msvc.rs:154:5:
  Configuring libffi: exit status: 1 (cd "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-e9834bcb452f6870/out/libffi-build" && CC="clang" CFLAGS="-O3 -ffunction-sections -fdata-sections -fPIC -gdwarf-4 -fno-omit-frame-pointer --target=aarch64-unknown-linux-gnu -Wno-implicit-function-declaration" LC_ALL="C" "sh" "./configure" "--with-pic" "--disable-shared" "--disable-docs" "--prefix" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2-tools/aarch64-unknown-linux-gnu/release/build/libffi-sys-e9834bcb452f6870/out/libffi-root")
  stack backtrace:
     0: __rustc::rust_begin_unwind
               at /checkout/library/std/src/panicking.rs:698:5
     1: core::panicking::panic_fmt
               at /checkout/library/core/src/panicking.rs:80:14
     2: build_script_build::common::run_command
               at ./build/common.rs:13:13
     3: build_script_build::not_msvc::configure_libffi
               at ./build/not_msvc.rs:154:5
     4: build_script_build::not_msvc::build_and_link
               at ./build/not_msvc.rs:39:5
     5: build_script_build::main
               at ./build/build.rs:19:9
     6: core::ops::function::FnOnce::call_once
               at /checkout/library/core/src/ops/function.rs:250:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

💔 Test for b2e203f failed: CI. Failed jobs:

@RalfJung
Copy link
Member

This still has

  checking for a race-free mkdir -p... ../install-sh -c -d

@ChrisDenton
Copy link
Member

Could you switch to system libffi instead of building from source? Or is that too ancient?

@Zalathar
Copy link
Contributor Author

Oh, it looks like libffi-sys 3.3.3 (current latest version) is not actually new enough, since libffi-rs/libffi-rs#177 was only merged a little over a week ago, and hasn't made its way into a release yet.

Closing this in favour of the GNU coreutils workaround at #147581.

@Zalathar Zalathar closed this Oct 11, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants