-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Bump libffi-sys to 3.3.3 to avoid CI failure #147579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This newer version of libffi-sys incorporates a `configure` script generated by a newer version of autoconf, which avoids an incompatibility with uutools.
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot has assigned @Mark-Simulacrum. Use |
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
Bump libffi-sys to 3.3.3 to avoid CI failure try-job: aarch64-gnu try-job: aarch64-gnu-debug try-job: aarch64-gnu-llvm=20
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20 |
This comment has been minimized.
This comment has been minimized.
Bump libffi-sys to 3.3.3 to avoid CI failure try-job: aarch64-gnu try-job: aarch64-gnu-debug try-job: aarch64-gnu-llvm-20
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20-1,aarch64-gnu-llvm-20-2 |
This comment has been minimized.
This comment has been minimized.
Bump libffi-sys to 3.3.3 to avoid CI failure try-job: aarch64-gnu try-job: aarch64-gnu-debug try-job: aarch64-gnu-llvm-20-1 try-job: aarch64-gnu-llvm-20-2
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test for b2e203f failed: CI. Failed jobs:
|
This still has
|
Could you switch to system libffi instead of building from source? Or is that too ancient? |
Oh, it looks like libffi-sys 3.3.3 (current latest version) is not actually new enough, since libffi-rs/libffi-rs#177 was only merged a little over a week ago, and hasn't made its way into a release yet. Closing this in favour of the GNU coreutils workaround at #147581. |
This is an attempt to work around the CI failures at #147556, by using a later version of libffi-sys.
The newer version of libffi-sys incorporates a
configure
script generated by a newer version of autoconf, which should avoid an (artificial) incompatibility with uutils.