Skip to content

ci: Use GNU coreutils to work around a libffi-sys build failure #147581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

ci: Use GNU coreutils to work around a libffi-sys build failure #147581

merged 1 commit into from
Oct 11, 2025
+6 −0

Conversation

Zalathar
Copy link
Contributor

This is an attempt to work around the CI failures at #147556, by switching back to GNU coreutils (instead of uutils) on the Ubuntu 25.10 jobs.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Contributor Author

@bors try jobs=aarch64-gnu,aarch64-gnu-debug,aarch64-gnu-llvm-20-1,aarch64-gnu-llvm-20-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 11, 2025
@rust-bors
Auto merge of #147581 - Zalathar:coreutils-from-gnu, r=<try>
7af80be 
ci: Use GNU coreutils to work around a libffi-sys build failure

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
try-job: aarch64-gnu-llvm-20-1
try-job: aarch64-gnu-llvm-20-2
@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

Umm, why have we even been using Ubuntu 25.10 when it wasn't even released yet...

@Zalathar Zalathar mentioned this pull request Oct 11, 2025
Closed
@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

@bors r+ p=101

Let's try in parallel if it helps.

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

📌 Commit 7f0adce has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2025
@RalfJung
Copy link
Member

Since the queue is stopped, I think we might a swell "try" this by just landing it -- it's not like that'd be wasting any queue time...

@Kobzol do we still have to be careful with approving a PR while a try build is ongoing, or is that mitigated now that try builds are done by new-bors?

@RalfJung
Copy link
Member

Ah okay, never mind. :)

@bors p=1001

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

Try and auto builds are completely separated now, so no need to wait. I approved the PR.

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

⌛ Testing commit 7f0adce with merge b3f8586...

@RalfJung
Copy link
Member

Hm, is it actually testing this now or not? The error is confusing, at the very least...

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

It is confusing indeed. https://bors.rust-lang.org/queue/rust it is being tested.

@Zalathar
Copy link
Contributor Author

Umm, why have we even been using Ubuntu 25.10 when it wasn't even released yet...

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

☀️ Try build successful (CI)
Build commit: 7af80be (7af80be95bc4bf61cf7d612fa95d0e157014662b, parent: 9725c4baacef19345e13f91b27e66e10ef5592ae)

@bors
Copy link
Collaborator

bors commented Oct 11, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing b3f8586 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 11, 2025
@bors bors merged commit b3f8586 into rust-lang:master Oct 11, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 11, 2025
@Zalathar Zalathar deleted the coreutils-from-gnu branch October 11, 2025 12:34
@RalfJung
Copy link
Member

@bors treeclosed-
This should fix things, hopefully :)

@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9725c4b (parent) -> b3f8586 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b3f8586fb1e4859678d6b231e780ff81801d2282 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7698.4s -> 6500.8s (-15.6%)
  2. dist-aarch64-apple: 7683.7s -> 6495.7s (-15.5%)
  3. dist-loongarch64-linux: 5270.0s -> 6082.5s (15.4%)
  4. dist-x86_64-apple: 7535.0s -> 6586.5s (-12.6%)
  5. dist-aarch64-msvc: 6167.9s -> 5519.9s (-10.5%)
  6. x86_64-gnu-miri: 4009.5s -> 4429.1s (10.5%)
  7. dist-apple-various: 3912.6s -> 3569.6s (-8.8%)
  8. tidy: 197.4s -> 180.1s (-8.8%)
  9. dist-various-1: 3892.0s -> 4163.2s (7.0%)
  10. dist-i586-gnu-i586-i686-musl: 5467.7s -> 5134.0s (-6.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar @rustbot @Kobzol @bors @RalfJung